Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: chrome/browser/resources/PRESUBMIT.py

Issue 760163004: Looking into all changed files to find actions.xml. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Look at all files in CL Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « PRESUBMIT_test_mocks.py ('k') | chrome/browser/resources/PRESUBMIT_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for HTML files in chrome/browser/resources. 5 """Presubmit script for HTML files in chrome/browser/resources.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
11 ACTION_XML_PATH = '../../../tools/metrics/actions/actions.xml' 11 ACTION_XML_PATH = '../../../tools/metrics/actions/actions.xml'
12 12
13 def CheckUserActionUpdate(input_api, output_api, action_xml_path): 13 def CheckUserActionUpdate(input_api, output_api, action_xml_path):
14 """Checks if any new user action has been added.""" 14 """Checks if any new user action has been added."""
15 if any('actions.xml' == input_api.os_path.basename(f.LocalPath()) for f in 15 if any('actions.xml' == input_api.os_path.basename(f) for f in
16 input_api.AffectedFiles()): 16 input_api.change.LocalPaths()):
17 # If actions.xml is already included in the changelist, the PRESUBMIT 17 # If actions.xml is already included in the changelist, the PRESUBMIT
18 # for actions.xml will do a more complete presubmit check. 18 # for actions.xml will do a more complete presubmit check.
19 return [] 19 return []
20 20
21 file_filter = lambda f: f.LocalPath().endswith('.html') 21 file_filter = lambda f: f.LocalPath().endswith('.html')
22 action_re = r'(^|\s+)metric\s*=\s*"([^ ]*)"' 22 action_re = r'(^|\s+)metric\s*=\s*"([^ ]*)"'
23 current_actions = None 23 current_actions = None
24 for f in input_api.AffectedFiles(file_filter=file_filter): 24 for f in input_api.AffectedFiles(file_filter=file_filter):
25 for line_num, line in f.ChangedContents(): 25 for line_num, line in f.ChangedContents():
26 match = input_api.re.search(action_re, line) 26 match = input_api.re.search(action_re, line)
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 return (match and 86 return (match and
87 any(input_api.re.search(type_re, match.group(i)) for i in (1, 3))) 87 any(input_api.re.search(type_re, match.group(i)) for i in (1, 3)))
88 88
89 89
90 def CheckChangeOnUpload(input_api, output_api): 90 def CheckChangeOnUpload(input_api, output_api):
91 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH) 91 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
92 92
93 93
94 def CheckChangeOnCommit(input_api, output_api): 94 def CheckChangeOnCommit(input_api, output_api):
95 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH) 95 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
OLDNEW
« no previous file with comments | « PRESUBMIT_test_mocks.py ('k') | chrome/browser/resources/PRESUBMIT_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698