chrome/browser/resources/PRESUBMIT.py - Issue 760163004: Looking into all changed files to find actions.xml.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 760163004: Looking into all changed files to find actions.xml. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Look at all files in CL Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/PRESUBMIT.py

diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py

index e22e2a09f825b0c5cdd9d2dcb3caf72bc5bd38e8..d603cc001878c93e39c0b23d385005b5f542a724 100644

--- a/chrome/browser/resources/PRESUBMIT.py

+++ b/chrome/browser/resources/PRESUBMIT.py

@@ -12,8 +12,8 @@ ACTION_XML_PATH = '../../../tools/metrics/actions/actions.xml'

def CheckUserActionUpdate(input_api, output_api, action_xml_path):

"""Checks if any new user action has been added."""

- if any('actions.xml' == input_api.os_path.basename(f.LocalPath()) for f in

- input_api.AffectedFiles()):

+ if any('actions.xml' == input_api.os_path.basename(f) for f in

+ input_api.change.LocalPaths()):

# If actions.xml is already included in the changelist, the PRESUBMIT

# for actions.xml will do a more complete presubmit check.

return []

« no previous file with comments | « PRESUBMIT_test_mocks.py ('k') | chrome/browser/resources/PRESUBMIT_test.py » ('j') | no next file with comments »