content/shell/browser/layout_test/layout_test_notification_manager.h - Issue 758603002: Use Mojo Permission Service when requesting Notifications permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_notification_manager.h

Issue 758603002: Use Mojo Permission Service when requesting Notifications permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_geolocation_follow_up

Patch Set: fixes to pass tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_content_browser_client.cc ('k') | content/shell/browser/layout_test/layout_test_notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_notification_manager.h

diff --git a/content/shell/browser/layout_test/layout_test_notification_manager.h b/content/shell/browser/layout_test/layout_test_notification_manager.h

index edccd4969150c4c37a1a7fc671738da015d2abd7..be79c5fe728518ed1a2035e6fd419877170723e9 100644

--- a/content/shell/browser/layout_test/layout_test_notification_manager.h

+++ b/content/shell/browser/layout_test/layout_test_notification_manager.h

@@ -27,14 +27,12 @@ class LayoutTestNotificationManager {

// Checks whether |origin| has permission to display notifications in tests.

// Must be called on the IO thread.

- blink::WebNotificationPermission CheckPermission(

- const GURL& origin);

+ blink::WebNotificationPermission CheckPermission(const GURL& origin);

// Requests permission for |origin| to display notifications in layout tests.

// Must be called on the IO thread.

- void RequestPermission(

- const GURL& origin,

- const base::Callback<void(bool)>& callback);

+ // Returns whether the permission is granted.

+ bool RequestPermission(const GURL& origin);

// Sets the permission to display notifications for |origin| to |permission|.

// Must be called on the IO thread.