content/shell/browser/layout_test/layout_test_notification_manager.cc - Issue 758603002: Use Mojo Permission Service when requesting Notifications permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_notification_manager.cc

Issue 758603002: Use Mojo Permission Service when requesting Notifications permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_geolocation_follow_up

Patch Set: fixes to pass tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/layout_test/layout_test_notification_manager.cc

diff --git a/content/shell/browser/layout_test/layout_test_notification_manager.cc b/content/shell/browser/layout_test/layout_test_notification_manager.cc

index 7366aabcd8f242d08132b18e17f63463a4bd0783..dd8fc22376a029ec3f2f1177474183da51384f37 100644

--- a/content/shell/browser/layout_test/layout_test_notification_manager.cc

+++ b/content/shell/browser/layout_test/layout_test_notification_manager.cc

@@ -27,12 +27,8 @@ LayoutTestNotificationManager::CheckPermission(const GURL& origin) {

return iter->second;

}

-void LayoutTestNotificationManager::RequestPermission(

- const GURL& origin,

- const base::Callback<void(bool)>& callback) {

- bool allowed =

- CheckPermission(origin) == blink::WebNotificationPermissionAllowed;

- callback.Run(allowed);

+bool LayoutTestNotificationManager::RequestPermission(const GURL& origin) {

+ return CheckPermission(origin) == blink::WebNotificationPermissionAllowed;

}

void LayoutTestNotificationManager::SetPermission(

« no previous file with comments | « content/shell/browser/layout_test/layout_test_notification_manager.h ('k') | no next file » | no next file with comments »