content/shell/browser/layout_test/layout_test_content_browser_client.cc - Issue 758603002: Use Mojo Permission Service when requesting Notifications permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_content_browser_client.cc

Issue 758603002: Use Mojo Permission Service when requesting Notifications permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_geolocation_follow_up

Patch Set: fixes to pass tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/notification_permission_dispatcher.cc ('k') | content/shell/browser/layout_test/layout_test_notification_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_content_browser_client.cc

diff --git a/content/shell/browser/layout_test/layout_test_content_browser_client.cc b/content/shell/browser/layout_test/layout_test_content_browser_client.cc

index 3a3a54c0d77221356949903399a5e7d01c5c3ae7..b4b2b08023aaf4608d4a8d38596164887c54e25b 100644

--- a/content/shell/browser/layout_test/layout_test_content_browser_client.cc

+++ b/content/shell/browser/layout_test/layout_test_content_browser_client.cc

@@ -24,10 +24,14 @@ void RequestDesktopNotificationPermissionOnIO(

const base::Callback<void(bool)>& callback) {

LayoutTestNotificationManager* manager =

LayoutTestContentBrowserClient::Get()->GetLayoutTestNotificationManager();

- if (manager)

- manager->RequestPermission(source_origin, callback);

- else

- callback.Run(true);

+ bool allowed = manager ? manager->RequestPermission(source_origin)

+ : true;

+ // The callback came from the UI thread, we need to run it from there again.

+ BrowserThread::PostTask(

+ BrowserThread::UI,

+ FROM_HERE,

+ base::Bind(callback, allowed));

}

} // namespace