Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 758223003: Cleanup: Use Bit('build_ARCH') instead of Bit('target_ARCH') (Closed)

Created:
6 years ago by Mark Seaborn
Modified:
6 years ago
Reviewers:
JF, Roland McGrath
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

Cleanup: Use Bit('build_ARCH') instead of Bit('target_ARCH') Remove the definitions of 'target_ARCH' in SConstruct. The distinction between "build" and "target" architecture is obsolete -- the two are always the same. BUG=https://code.google.com/p/nativeclient/issues/detail?id=2703 TEST=trybots Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=14161

Patch Set 1 #

Patch Set 2 : Fix + simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -102 lines) Patch
M SConstruct View 1 15 chunks +22 lines, -42 lines 0 comments Download
M site_scons/site_tools/library_deps.py View 1 chunk +1 line, -1 line 0 comments Download
M site_scons/site_tools/naclsdk.py View 3 chunks +6 lines, -6 lines 0 comments Download
M src/nonsfi/linux/nacl.scons View 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/cpu_features/build.scons View 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/platform_qualify/build.scons View 2 chunks +3 lines, -3 lines 0 comments Download
M src/trusted/sel_universal/build.scons View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/build.scons View 13 chunks +23 lines, -23 lines 0 comments Download
M src/trusted/service_runtime/nacl.scons View 2 chunks +8 lines, -8 lines 0 comments Download
M src/trusted/validator/build.scons View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/validator_arm/build.scons View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/validator_ragel/build.scons View 3 chunks +3 lines, -3 lines 0 comments Download
M src/trusted/validator_x86/build.scons View 1 chunk +1 line, -1 line 0 comments Download
M src/untrusted/nacl/nacl.scons View 1 chunk +1 line, -1 line 0 comments Download
M src/untrusted/pnacl_dynloader/nacl.scons View 1 chunk +1 line, -1 line 0 comments Download
M src/untrusted/pthread/nacl.scons View 1 chunk +2 lines, -2 lines 0 comments Download
M src/untrusted/valgrind/nacl.scons View 1 chunk +1 line, -1 line 0 comments Download
M tests/gdb/nacl.scons View 1 chunk +1 line, -1 line 0 comments Download
M tools/scons_to_gn/test.scons View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Mark Seaborn
6 years ago (2014-12-01 17:01:21 UTC) #2
Roland McGrath
lgtm
6 years ago (2014-12-02 18:47:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758223003/20001
6 years ago (2014-12-02 18:50:45 UTC) #5
commit-bot: I haz the power
Presubmit check for 758223003-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-02 18:51:12 UTC) #7
Mark Seaborn
+JF: Can you do an OWNERS sign-off for validator_arm/?
6 years ago (2014-12-02 19:00:20 UTC) #9
JF
src/trusted/validator_arm/* lgtm
6 years ago (2014-12-02 19:16:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758223003/20001
6 years ago (2014-12-02 19:17:04 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-02 21:03:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/native_client?view=rev&revision=14161

Powered by Google App Engine
This is Rietveld 408576698