Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: src/trusted/validator_ragel/build.scons

Issue 758223003: Cleanup: Use Bit('build_ARCH') instead of Bit('target_ARCH') (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Fix + simplify Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/trusted/validator_arm/build.scons ('k') | src/trusted/validator_x86/build.scons » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # -*- python -*- 1 # -*- python -*-
2 # Copyright (c) 2012 The Native Client Authors. All rights reserved. 2 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import json 6 import json
7 import hashlib 7 import hashlib
8 import os 8 import os
9 import platform 9 import platform
10 import sys 10 import sys
(...skipping 29 matching lines...) Expand all
40 validator64 = env.ComponentObject('gen/validator_x86_64.c') 40 validator64 = env.ComponentObject('gen/validator_x86_64.c')
41 41
42 features = [ 42 features = [
43 env.ComponentObject('validator_features_all.c'), 43 env.ComponentObject('validator_features_all.c'),
44 env.ComponentObject('validator_features_validator.c') 44 env.ComponentObject('validator_features_validator.c')
45 ] 45 ]
46 46
47 # Glue library called from service runtime. The source file depends on the 47 # Glue library called from service runtime. The source file depends on the
48 # target architecture. In library_deps.py this library is marked as 48 # target architecture. In library_deps.py this library is marked as
49 # dependant of dfa_validate_x86_xx. 49 # dependant of dfa_validate_x86_xx.
50 if env.Bit('target_x86'): 50 if env.Bit('build_x86'):
51 caller_lib = 'dfa_validate_caller_x86_%s' % env.get('TARGET_SUBARCH') 51 caller_lib = 'dfa_validate_caller_x86_%s' % env.get('TARGET_SUBARCH')
52 env.ComponentLibrary( 52 env.ComponentLibrary(
53 caller_lib, 53 caller_lib,
54 ['dfa_validate_%s.c' % env.get('TARGET_SUBARCH'), 54 ['dfa_validate_%s.c' % env.get('TARGET_SUBARCH'),
55 {'32': validator32, '64': validator64}[env.get('TARGET_SUBARCH')], 55 {'32': validator32, '64': validator64}[env.get('TARGET_SUBARCH')],
56 'dfa_validate_common.c', 56 'dfa_validate_common.c',
57 features]) 57 features])
58 58
59 # Low-level platform-independent interface supporting both 32 and 64 bit, 59 # Low-level platform-independent interface supporting both 32 and 64 bit,
60 # used in ncval and in validator_benchmark. 60 # used in ncval and in validator_benchmark.
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 492
493 for bits in ['32', '64']: 493 for bits in ['32', '64']:
494 tests_mask = ( 494 tests_mask = (
495 '${MAIN_DIR}/src/trusted/validator_ragel/testdata/%s/*.test' % bits) 495 '${MAIN_DIR}/src/trusted/validator_ragel/testdata/%s/*.test' % bits)
496 496
497 if env.Bit('regenerate_golden'): 497 if env.Bit('regenerate_golden'):
498 update_option = ['--update'] 498 update_option = ['--update']
499 else: 499 else:
500 update_option = [] 500 update_option = []
501 501
502 if env.Bit('target_x86'): 502 if env.Bit('build_x86'):
503 # In principle we can run these tests on ARM too, but first, there is no 503 # In principle we can run these tests on ARM too, but first, there is no
504 # reason to, and second, there are problems with those bots that build 504 # reason to, and second, there are problems with those bots that build
505 # on one machine and run tests on another (build machine does not recognize 505 # on one machine and run tests on another (build machine does not recognize
506 # than new ncval is needed, so it's not copied to the test machine). 506 # than new ncval is needed, so it's not copied to the test machine).
507 rdfaval = '$STAGING_DIR/ncval_new$PROGSUFFIX' 507 rdfaval = '$STAGING_DIR/ncval_new$PROGSUFFIX'
508 rdfa_targeted_test = env.AutoDepsCommand( 508 rdfa_targeted_test = env.AutoDepsCommand(
509 'run_rdfa_targeted_tests_%s.out' % bits, 509 'run_rdfa_targeted_tests_%s.out' % bits,
510 ['${PYTHON}', 510 ['${PYTHON}',
511 env.File('run_rdfa_validator_tests.py'), 511 env.File('run_rdfa_validator_tests.py'),
512 '--rdfaval', env.File(rdfaval), 512 '--rdfaval', env.File(rdfaval),
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 ['small_tests', 'validator_tests'], 553 ['small_tests', 'validator_tests'],
554 node_name='run_spec_val_test_%s' % bits) 554 node_name='run_spec_val_test_%s' % bits)
555 555
556 if env.Bit('regenerate_golden'): 556 if env.Bit('regenerate_golden'):
557 # Don't want these tests run in parallel because they write 557 # Don't want these tests run in parallel because they write
558 # to .test files. 558 # to .test files.
559 SideEffect(tests_mask, spec_test) 559 SideEffect(tests_mask, spec_test)
560 560
561 # Spec test uses @dis section in test files, which in turn is updated 561 # Spec test uses @dis section in test files, which in turn is updated
562 # by dis_section_test. 562 # by dis_section_test.
563 if env.Bit('target_x86'): 563 if env.Bit('build_x86'):
564 env.Depends(spec_test, dis_section_test) 564 env.Depends(spec_test, dis_section_test)
OLDNEW
« no previous file with comments | « src/trusted/validator_arm/build.scons ('k') | src/trusted/validator_x86/build.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698