Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: site_scons/site_tools/naclsdk.py

Issue 758223003: Cleanup: Use Bit('build_ARCH') instead of Bit('target_ARCH') (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Fix + simplify Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site_scons/site_tools/library_deps.py ('k') | src/nonsfi/linux/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site_scons/site_tools/naclsdk.py
diff --git a/site_scons/site_tools/naclsdk.py b/site_scons/site_tools/naclsdk.py
index 062a0d748e4df7d0369f6950fce4de0c88e65f3b..441fa43a36e90b4487fe46dbdbb41448618e0170 100755
--- a/site_scons/site_tools/naclsdk.py
+++ b/site_scons/site_tools/naclsdk.py
@@ -337,7 +337,7 @@ def PNaClForceNative(env):
# Get an environment for nacl-gcc when in PNaCl mode.
def PNaClGetNNaClEnv(env):
assert(env.Bit('bitcode'))
- assert(not env.Bit('target_mips32'))
+ assert(not env.Bit('build_mips32'))
# This is kind of a hack. We clone the environment,
# clear the bitcode bit, and then reload naclsdk.py
@@ -372,13 +372,13 @@ def AddBiasForPNaCl(env, temporarily_allow=True):
CXX='NO-NATIVE-CXX-INVOCATION-ALLOWED')
return
- if env.Bit('target_arm'):
+ if env.Bit('build_arm'):
bias_flag = '--pnacl-bias=arm'
- elif env.Bit('target_x86_32'):
+ elif env.Bit('build_x86_32'):
bias_flag = '--pnacl-bias=x86-32'
- elif env.Bit('target_x86_64'):
+ elif env.Bit('build_x86_64'):
bias_flag = '--pnacl-bias=x86-64'
- elif env.Bit('target_mips32'):
+ elif env.Bit('build_mips32'):
bias_flag = '--pnacl-bias=mips32'
else:
raise Exception("Unknown architecture!")
@@ -689,7 +689,7 @@ def generate(env):
else:
_SetEnvForNativeSdk(env, root)
- if (env.Bit('bitcode') or env.Bit('nacl_clang')) and env.Bit('target_x86'):
+ if (env.Bit('bitcode') or env.Bit('nacl_clang')) and env.Bit('build_x86'):
# Get GDB from the nacl-gcc toolchain even when using PNaCl.
# TODO(mseaborn): We really want the nacl-gdb binary to be in a
# separate tarball from the nacl-gcc toolchain, then this step
« no previous file with comments | « site_scons/site_tools/library_deps.py ('k') | src/nonsfi/linux/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698