Add chrome.loadAsync capability to ChromeDriver, which allows the user not to

Add chrome.loadAsync capability to ChromeDriver, which allows the user not to
wait for page loads.
Also, be able to launch chromium and chrome regardless of what branding
we're built with.
BUG=89757
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96265

[Huyen, 2011-08-08 17:53:12]

http://codereview.chromium.org/7582005/diff/2002/chrome/test/webdriver/automa...
File chrome/test/webdriver/automation.cc (right):

http://codereview.chromium.org/7582005/diff/2002/chrome/test/webdriver/automa...
chrome/test/webdriver/automation.cc:164: // Loop through the browser executable
paths (|browser_exes|). For each
Code above is similar, maybe move it into a method for reuse?

[Huyen, 2011-08-08 20:51:18]

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/comman...
File chrome/test/webdriver/commands/create_session.cc (right):

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/create_session.cc:50: if
(dict->GetWithoutPathExpansion(key, &value)) {
Did you mean to do a Set here?

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/sessio...
File chrome/test/webdriver/session.cc (right):

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/sessio...
chrome/test/webdriver/session.cc:101: Error* Session::BeforeExecuteCommand() {
Does the addition of this method imply all later synchronous commands will need
to call this?

[kkania, 2011-08-09 17:10:24]

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/comman...
File chrome/test/webdriver/commands/create_session.cc (right):

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/create_session.cc:50: if
(dict->GetWithoutPathExpansion(key, &value)) {
On 2011/08/08 20:51:18, Huyen wrote:
> Did you mean to do a Set here?

No

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/sessio...
File chrome/test/webdriver/session.cc (right):

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/sessio...
chrome/test/webdriver/session.cc:101: Error* Session::BeforeExecuteCommand() {
Yes, although all commands call this indirectly through WebDriverCommand::Init

[Huyen, 2011-08-09 18:10:02]

lgtm

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/comman...
File chrome/test/webdriver/commands/create_session.cc (right):

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/create_session.cc:50: if
(dict->GetWithoutPathExpansion(key, &value)) {
Per offline conversation, please change name of this method.

On 2011/08/09 17:10:24, kkania wrote:
> On 2011/08/08 20:51:18, Huyen wrote:
> > Did you mean to do a Set here?
> 
> No

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/sessio...
File chrome/test/webdriver/session.cc (right):

http://codereview.chromium.org/7582005/diff/8001/chrome/test/webdriver/sessio...
chrome/test/webdriver/session.cc:101: Error* Session::BeforeExecuteCommand() {
On 2011/08/09 17:10:24, kkania wrote:
> Yes, although all commands call this indirectly through WebDriverCommand::Init

Got it.

[commit-bot: I haz the power, 2011-08-09 23:55:37]

Try job failure for 7582005-15002 (retry) on mac for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2011-08-11 00:04:58]

Change committed as 96265