Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1968)

Unified Diff: chrome/test/webdriver/commands/webdriver_command.cc

Issue 7582005: Add chrome.loadAsync capability to ChromeDriver, which allows the user not to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/set_timeout_commands_unittest.cc ('k') | chrome/test/webdriver/session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/webdriver_command.cc
diff --git a/chrome/test/webdriver/commands/webdriver_command.cc b/chrome/test/webdriver/commands/webdriver_command.cc
index f7000da8e77407d2468a46f258b8cf8aeb1dc86a..094f65560ad338a9889fdc2fa25532126a52b42e 100644
--- a/chrome/test/webdriver/commands/webdriver_command.cc
+++ b/chrome/test/webdriver/commands/webdriver_command.cc
@@ -41,19 +41,11 @@ bool WebDriverCommand::Init(Response* const response) {
return false;
}
- LOG(INFO) << "Waiting for the page to stop loading";
- Error* error = session_->WaitForAllTabsToStopLoading();
+ Error* error = session_->BeforeExecuteCommand();
if (error) {
response->SetError(error);
return false;
}
- LOG(INFO) << "Done waiting for the page to stop loading";
- error = session_->SwitchToTopFrameIfCurrentFrameInvalid();
- if (error) {
- response->SetError(error);
- return false;
- }
-
response->SetField("sessionId", Value::CreateStringValue(session_id));
return true;
}
« no previous file with comments | « chrome/test/webdriver/commands/set_timeout_commands_unittest.cc ('k') | chrome/test/webdriver/session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698