chrome/test/webdriver/commands/session_with_id.cc - Issue 7582005: Add chrome.loadAsync capability to ChromeDriver, which allows the user not to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/commands/session_with_id.cc

Issue 7582005: Add chrome.loadAsync capability to ChromeDriver, which allows the user not to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix mac Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/webdriver/commands/create_session.cc ('k') | chrome/test/webdriver/commands/set_timeout_commands_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/webdriver/commands/session_with_id.cc

diff --git a/chrome/test/webdriver/commands/session_with_id.cc b/chrome/test/webdriver/commands/session_with_id.cc

index 24cbe8c704bc223385760c50062228971d20ec7b..1c5788221657ef027640e070478f99eb815aab04 100644

--- a/chrome/test/webdriver/commands/session_with_id.cc

+++ b/chrome/test/webdriver/commands/session_with_id.cc

@@ -56,13 +56,11 @@ void SessionWithID::ExecuteGet(Response* const response) {

// Custom non-standard session info.

temp_value->SetWithoutPathExpansion(

- "chrome.chromedriverVersion", Value::CreateStringValue("1.0"));

- temp_value->SetWithoutPathExpansion(

- "chrome.automationVersion",

+ "chrome.chromedriverVersion",

Value::CreateStringValue(chrome::kChromeVersion));

temp_value->SetWithoutPathExpansion(

"chrome.nativeEvents",

- Value::CreateBooleanValue(session_->use_native_events()));

+ Value::CreateBooleanValue(session_->options().use_native_events));

response->SetValue(temp_value);

}