Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 756413002: gn format: Fix and enable a few more tests (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-wrap-fix
Project:
chromium
Visibility:
Public.

Description

gn format: Fix and enable a few more tests This follows on https://codereview.chromium.org/748863003/ and takes care of a few edge cases that were causing ugly output. After this CL, I'm happy enough with the output of reformatting all (https://codereview.chromium.org/704363002) to say it's generally useful. R=brettw@chromium.org BUG=348474 Committed: https://crrev.com/25919ddcafc0615936c49bebd0b34a6976cd26d7 Cr-Commit-Position: refs/heads/master@{#305898}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 2

Patch Set 8 : fix extra indent on continued binop #

Patch Set 9 : . #

Patch Set 10 : rebase #

Patch Set 11 : x64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -53 lines) Patch
M tools/gn/command_format.cc View 1 2 3 4 5 6 7 8 9 10 15 chunks +76 lines, -28 lines 0 comments Download
M tools/gn/command_format_unittest.cc View 1 2 3 4 5 9 1 chunk +7 lines, -3 lines 0 comments Download
M tools/gn/format_test_data/025.golden View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gn/format_test_data/026.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/format_test_data/026.golden View 1 2 3 4 5 6 7 1 chunk +7 lines, -5 lines 0 comments Download
M tools/gn/format_test_data/039.golden View 1 2 3 4 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/format_test_data/043.gn View 1 2 3 9 1 chunk +3 lines, -2 lines 0 comments Download
M tools/gn/format_test_data/043.golden View 1 2 3 9 1 chunk +5 lines, -3 lines 0 comments Download
M tools/gn/format_test_data/050.golden View 1 2 3 4 5 6 7 9 1 chunk +7 lines, -7 lines 0 comments Download
A tools/gn/format_test_data/052.golden View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/053.gn View 1 chunk +7 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/053.golden View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/054.gn View 1 chunk +7 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/054.golden View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/055.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/055.golden View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/056.gn View 1 2 3 4 5 6 1 chunk +45 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/056.golden View 1 2 3 4 5 6 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
scottmg
6 years ago (2014-11-26 07:57:52 UTC) #1
brettw
lgtm https://codereview.chromium.org/756413002/diff/120001/tools/gn/format_test_data/026.golden File tools/gn/format_test_data/026.golden (right): https://codereview.chromium.org/756413002/diff/120001/tools/gn/format_test_data/026.golden#newcode2 tools/gn/format_test_data/026.golden:2: rebase_path("$target_gen_dir/experimental-libraries.cc", root_build_dir), This is interesting. I was going ...
6 years ago (2014-11-26 18:32:07 UTC) #2
scottmg
https://codereview.chromium.org/756413002/diff/120001/tools/gn/format_test_data/026.golden File tools/gn/format_test_data/026.golden (right): https://codereview.chromium.org/756413002/diff/120001/tools/gn/format_test_data/026.golden#newcode2 tools/gn/format_test_data/026.golden:2: rebase_path("$target_gen_dir/experimental-libraries.cc", root_build_dir), On 2014/11/26 18:32:07, brettw wrote: > This ...
6 years ago (2014-11-26 18:39:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756413002/180001
6 years ago (2014-11-26 21:05:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756413002/200001
6 years ago (2014-11-26 21:33:14 UTC) #7
commit-bot: I haz the power
Committed patchset #11 (id:200001)
6 years ago (2014-11-26 22:13:12 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-26 22:13:56 UTC) #9
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/25919ddcafc0615936c49bebd0b34a6976cd26d7
Cr-Commit-Position: refs/heads/master@{#305898}

Powered by Google App Engine
This is Rietveld 408576698