tools/gn/format_test_data/026.golden - Issue 756413002: gn format: Fix and enable a few more tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/format_test_data/026.golden

Issue 756413002: gn format: Fix and enable a few more tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-wrap-fix

Patch Set: . Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 args = [	1 args = [

2 rebase_path("$target_gen_dir/experimental-libraries.cc", root_build_dir),	2 rebase_path("$target_gen_dir/experimental-libraries.cc", root_build_dir),
	brettw 2014/11/26 18:32:07 This is interesting. I was going to say this is wr This is interesting. I was going to say this is wrong, but actually might be a better way to format this. scottmg 2014/11/26 18:39:54 Yeah, the special formatting for lists is a bit we Show quoted text On 2014/11/26 18:32:07, brettw wrote: > This is interesting. I was going to say this is wrong, but actually might be a > better way to format this. Yeah, the special formatting for lists is a bit weird. It's special cased because sources = [ "a", "b", ] feels nicer than indented, but there's an indent on continuations in general so the extra indent happens when there's a plus or something. i felt like it was ok because it was a cue that there was something hiding at the end. in some cases rewriting args = [ some_long_multiline_thing ] + something_else would probably be better written as args = [ some_long_multiline_thing ] args += something_else anyway which would remove the extra indent. there's an example that i'll probably do that for here: https://codereview.chromium.org/704363002/diff/140001/BUILD.gn
3 "EXPERIMENTAL",	3 "EXPERIMENTAL",

4 v8_compress_startup_data,	4 v8_compress_startup_data,

5 ] + rebase_path(sources, root_build_dir)	5 ] + rebase_path(sources, root_build_dir)

OLD	NEW

« no previous file with comments | « tools/gn/format_test_data/025.golden ('k') | tools/gn/format_test_data/043.gn » ('j') | no next file with comments »