Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/gn/command_format_unittest.cc

Issue 756413002: gn format: Fix and enable a few more tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-wrap-fix
Patch Set: x64 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_format.cc ('k') | tools/gn/format_test_data/025.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_format_unittest.cc
diff --git a/tools/gn/command_format_unittest.cc b/tools/gn/command_format_unittest.cc
index 32b8fcebd1debc70aa119030d0c3649936c43c7c..fe4c050d7309ab39cbb93d8395a87d8fe964e7eb 100644
--- a/tools/gn/command_format_unittest.cc
+++ b/tools/gn/command_format_unittest.cc
@@ -77,14 +77,18 @@ FORMAT_TEST(039)
// TODO(scottmg): Bad break, exceeding 80 col: FORMAT_TEST(040)
FORMAT_TEST(041)
FORMAT_TEST(042)
-// TODO(scottmg): Unnecessary line break: FORMAT_TEST(043)
+FORMAT_TEST(043)
// TODO(scottmg): Dewrapped caused exceeding 80 col: FORMAT_TEST(044)
FORMAT_TEST(045)
FORMAT_TEST(046)
FORMAT_TEST(047)
-// TODO(scottmg): Unnecessary blank line inserted: FORMAT_TEST(048)
+FORMAT_TEST(048)
// TODO(scottmg): Eval is broken (!) and comment output might have extra ,
// FORMAT_TEST(049)
FORMAT_TEST(050)
FORMAT_TEST(051)
-// TODO(scottmg): Ugly separation: FORMAT_TEST(052)
+FORMAT_TEST(052)
+FORMAT_TEST(053)
+FORMAT_TEST(054)
+FORMAT_TEST(055)
+FORMAT_TEST(056)
« no previous file with comments | « tools/gn/command_format.cc ('k') | tools/gn/format_test_data/025.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698