Issue 756183004: Get rid of background-clip:text and PaintBehaviorForceBlackText.

Issue 756183004: Get rid of background-clip:text and PaintBehaviorForceBlackText. (Closed)

Created:
6 years ago by ojan

Modified:
6 years ago

Reviewers:
eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Get rid of background-clip:text and PaintBehaviorForceBlackText. http://blog.ericzhang.com/punch-through-text-masks-with-css-and-html5/ shows that you can achieve the similar effects using canvas. This doesn't need to be built into the core engine. It's OK for this to require more than a line of CSS to achieve. Unfortunately, the test included this this patch doesn't actually show that I didn't break anything because background-image is broken. I got the test from https://chromium.googlesource.com/chromium/blink/+/47e0d126e8d459b10176e3a91e47cf62ce0953a5%5E%21/#F4 R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/20143b76b850123c3d9ec4f375b004e859674465

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -104 lines)			Patch
M	sky/engine/core/css/CSSPrimitiveValueMappings.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/rendering/EllipsisBox.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/InlineTextBox.cpp	View	1	3 chunks	+11 lines, -38 lines	0 comments	Download
M	sky/engine/core/rendering/PaintInfo.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/PaintPhase.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderBoxModelObject.cpp	View		2 chunks	+0 lines, -38 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayer.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderView.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/style/FillLayer.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyleConstants.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/platform/graphics/Color.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/platform/graphics/Color.cpp	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
A	sky/tests/clipping/background-opaque-clipped-gradients.sky	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	sky/tests/clipping/background-opaque-clipped-gradients-expected.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

ojan

background-image bug filed in https://code.google.com/p/chromium/issues/detail?id=438913.

6 years ago (2014-12-04 04:34:10 UTC) #1

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

6 years ago (2014-12-04 18:38:50 UTC) #6

ojan

6 years ago (2014-12-04 20:15:44 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
20143b76b850123c3d9ec4f375b004e859674465.