sky/engine/core/rendering/RenderLayer.cpp - Issue 756183004: Get rid of background-clip:text and PaintBehaviorForceBlackText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderLayer.cpp

Issue 756183004: Get rid of background-clip:text and PaintBehaviorForceBlackText. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Remove forceBlackText Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderLayer.cpp

diff --git a/sky/engine/core/rendering/RenderLayer.cpp b/sky/engine/core/rendering/RenderLayer.cpp

index 73cd995884bb0b4aeff1593410922f20efabff4c..df6f3dd2c3f33f996795b071fc45cb20965bc810 100644

--- a/sky/engine/core/rendering/RenderLayer.cpp

+++ b/sky/engine/core/rendering/RenderLayer.cpp

@@ -1136,8 +1136,6 @@ void RenderLayer::paintLayerContents(GraphicsContext* context, const LayerPainti

if (localPaintingInfo.paintingRoot && !renderer()->isDescendantOf(localPaintingInfo.paintingRoot))

paintingRootForRenderer = localPaintingInfo.paintingRoot;

- ASSERT(!(localPaintingInfo.paintBehavior & PaintBehaviorForceBlackText));

bool shouldPaintBackground = isPaintingCompositedBackground && shouldPaintContent;

bool shouldPaintNegZOrderList = !isPaintingScrollingContent && isPaintingCompositedBackground;

bool shouldPaintOwnContents = isPaintingCompositedForeground && shouldPaintContent;