sky/engine/core/rendering/EllipsisBox.cpp - Issue 756183004: Get rid of background-clip:text and PaintBehaviorForceBlackText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/EllipsisBox.cpp

Issue 756183004: Get rid of background-clip:text and PaintBehaviorForceBlackText. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Remove forceBlackText Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/EllipsisBox.cpp

diff --git a/sky/engine/core/rendering/EllipsisBox.cpp b/sky/engine/core/rendering/EllipsisBox.cpp

index 86e63d1e8d32ce3a911cd0190297c8c281ef1558..47147a96921f84ca2081e19f8d71a0f3f643da15 100644

--- a/sky/engine/core/rendering/EllipsisBox.cpp

+++ b/sky/engine/core/rendering/EllipsisBox.cpp

@@ -53,7 +53,7 @@ void EllipsisBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, La

paintSelection(context, boxOrigin, style, font);

// Select the correct color for painting the text.

- Color foreground = paintInfo.forceBlackText() ? Color::black : renderer().selectionForegroundColor();

+ Color foreground = renderer().selectionForegroundColor();

if (foreground != styleTextColor)

context->setFillColor(foreground);

}