Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 755883006: Remove unused roles(EditableText, SplitGroup, GrowArea) from Chromium. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, stevenjb+watch_chromium.org, jochen+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused roles(EditableText, SplitGroup, GrowArea) from Chromium. This CL removes unused roles from chromium. 1. SplitGroup role 2. GrowArea role 3. EditableText role A blink side patch will follow this to remove above unused roles from blink as well. BUG=436808 Committed: https://crrev.com/d08dba3e24a145f38a537346d80603a6779c5818 Cr-Commit-Position: refs/heads/master@{#306403}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase changes #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -60 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/unit/test.js View 1 2 3 2 chunks +4 lines, -11 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 4 chunks +1 line, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
shreeramk
Please review. Thanks!!
6 years ago (2014-11-25 13:28:29 UTC) #2
dmazzoni
lgtm
6 years ago (2014-11-25 17:23:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755883006/20001
6 years ago (2014-11-25 17:24:23 UTC) #5
shreeramk
On 2014/11/25 17:24:23, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years ago (2014-11-26 03:49:05 UTC) #7
shreeramk
@Dominic: This can be CQed?
6 years ago (2014-11-26 19:06:42 UTC) #8
shreeramk
On 2014/11/26 19:06:42, shreeramk wrote: > @Dominic: This can be CQed? This need to be ...
6 years ago (2014-11-26 19:20:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755883006/40001
6 years ago (2014-11-27 05:49:11 UTC) #11
shreeramk
On 2014/11/27 05:49:11, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years ago (2014-11-27 07:44:52 UTC) #13
dmazzoni
On 2014/11/27 07:44:52, shreeramk wrote: > On 2014/11/27 05:49:11, I haz the power (commit-bot) wrote: ...
6 years ago (2014-11-27 07:52:01 UTC) #14
shreeramk
aboxhall@chromium.org: Please review changes in automation_node.js Thanks!!
6 years ago (2014-11-27 10:18:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755883006/60001
6 years ago (2014-11-27 10:53:00 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/26978)
6 years ago (2014-11-27 10:56:45 UTC) #20
shreeramk
On 2014/11/27 10:56:45, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-11-30 12:57:20 UTC) #21
aboxhall
lgtm for Automation API changes. Apologies for the slow response!
6 years ago (2014-12-02 16:47:50 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755883006/60001
6 years ago (2014-12-02 16:55:29 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-02 16:58:33 UTC) #27
commit-bot: I haz the power
6 years ago (2014-12-02 16:59:49 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d08dba3e24a145f38a537346d80603a6779c5818
Cr-Commit-Position: refs/heads/master@{#306403}

Powered by Google App Engine
This is Rietveld 408576698