Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 758393002: Removing unused roles(7) from chromium. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing unused roles(7) from chromium. BrowserRole DrawerRole HelpTagRole MatteRole RulerMarkerRole SheetRole SystemWideRole ValueIndicatorRole BUG=436808 Committed: https://crrev.com/7edde3f047fe95e336379792c01c3ffb6a068f5a Cr-Commit-Position: refs/heads/master@{#305839}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -72 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 7 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 1 7 chunks +0 lines, -8 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 8 chunks +0 lines, -16 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 8 chunks +0 lines, -16 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 7 chunks +0 lines, -8 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 7 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!!!
6 years ago (2014-11-26 11:39:37 UTC) #2
dmazzoni
lgtm
6 years ago (2014-11-26 17:47:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758393002/20001
6 years ago (2014-11-26 17:48:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-26 18:33:33 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-26 18:34:31 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7edde3f047fe95e336379792c01c3ffb6a068f5a
Cr-Commit-Position: refs/heads/master@{#305839}

Powered by Google App Engine
This is Rietveld 408576698