content/browser/accessibility/browser_accessibility_android.cc - Issue 755883006: Remove unused roles(EditableText, SplitGroup, GrowArea) from Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 755883006: Remove unused roles(EditableText, SplitGroup, GrowArea) from Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index 53189cbf1d11b1b3d939ba9a763c3e296a22464e..ce8f46d398edadc0a2d59c7499e118e2d2a17ab1 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -169,8 +169,7 @@ bool BrowserAccessibilityAndroid::IsDismissable() const {

}

bool BrowserAccessibilityAndroid::IsEditableText() const {

- return (GetRole() == ui::AX_ROLE_EDITABLE_TEXT ||

- GetRole() == ui::AX_ROLE_TEXT_AREA ||

+ return (GetRole() == ui::AX_ROLE_TEXT_AREA ||

GetRole() == ui::AX_ROLE_TEXT_FIELD);

}

@@ -247,7 +246,6 @@ const char* BrowserAccessibilityAndroid::GetClassName() const {

const char* class_name = NULL;

switch(GetRole()) {

- case ui::AX_ROLE_EDITABLE_TEXT:

case ui::AX_ROLE_SPIN_BUTTON:

case ui::AX_ROLE_TEXT_AREA:

case ui::AX_ROLE_TEXT_FIELD:

@@ -334,7 +332,6 @@ base::string16 BrowserAccessibilityAndroid::GetText() const {

switch (GetRole()) {

case ui::AX_ROLE_COMBO_BOX:

- case ui::AX_ROLE_EDITABLE_TEXT:

case ui::AX_ROLE_POP_UP_BUTTON:

case ui::AX_ROLE_TEXT_AREA:

case ui::AX_ROLE_TEXT_FIELD:

@@ -371,7 +368,6 @@ base::string16 BrowserAccessibilityAndroid::GetText() const {

base::string16 placeholder;

switch (GetRole()) {

case ui::AX_ROLE_DATE:

- case ui::AX_ROLE_EDITABLE_TEXT:

case ui::AX_ROLE_TEXT_AREA:

case ui::AX_ROLE_TEXT_FIELD:

case ui::AX_ROLE_TIME: