Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: tools/perf/measurements/screenshot_unittest.py

Issue 755323012: [Telemetry] Stop execution for unexpected exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Really fix screenshot exception. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/screenshot.py ('k') | tools/perf/measurements/smoothness_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/screenshot_unittest.py
diff --git a/tools/perf/measurements/screenshot_unittest.py b/tools/perf/measurements/screenshot_unittest.py
index b06f9c87d5201a73ad97fc7f2ca9ecac6fbf8b87..ac6e9be396800af39ee55ce056cb8d81c84e2351 100644
--- a/tools/perf/measurements/screenshot_unittest.py
+++ b/tools/perf/measurements/screenshot_unittest.py
@@ -8,6 +8,7 @@ import tempfile
from measurements import screenshot
from telemetry import benchmark
+from telemetry.page import page_test
from telemetry.unittest_util import options_for_unittests
from telemetry.unittest_util import page_test_test_case
@@ -24,9 +25,10 @@ class ScreenshotUnitTest(page_test_test_case.PageTestTestCase):
def testScreenshot(self):
ps = self.CreatePageSetFromFileInUnittestDataDir('blank.html')
measurement = screenshot.Screenshot(self._png_outdir)
- results = self.RunMeasurement(measurement, ps, options=self._options)
- if results.failures:
- logging.warning(str(results.failures))
+ try:
+ results = self.RunMeasurement(measurement, ps, options=self._options)
+ except page_test.TestNotSupportedOnPlatformError as e:
+ logging.warning(e)
return
saved_picture_count = results.FindAllPageSpecificValuesNamed(
« no previous file with comments | « tools/perf/measurements/screenshot.py ('k') | tools/perf/measurements/smoothness_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698