Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 754923002: Roll breakpad to r1405 and add microdump_stackwalk to build files. (Closed)

Created:
6 years ago by Primiano Tucci (use gerrit)
Modified:
6 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, mmandlis, Mark Mentovai
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll breakpad to r1405 and add microdump_stackwalk to build files. This rolls the following into breakpad: r1405 Introduce microdump_stackwalk comand line executable BUG=410294 Committed: https://crrev.com/cea221bc9d741848e165e4d7ae93a31bb76cc682 Cr-Commit-Position: refs/heads/master@{#305683}

Patch Set 1 #

Patch Set 2 : Roll for real #

Patch Set 3 : Fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -18 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 1 2 4 chunks +37 lines, -6 lines 0 comments Download
M breakpad/breakpad.gyp View 1 2 4 chunks +36 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Primiano Tucci (use gerrit)
Lei, can I ask you for another small review here (just two makefiles)? This is ...
6 years ago (2014-11-25 12:41:20 UTC) #2
Lei Zhang
lgtm
6 years ago (2014-11-25 18:38:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754923002/40001
6 years ago (2014-11-25 18:57:33 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-11-25 20:18:41 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-25 20:19:53 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cea221bc9d741848e165e4d7ae93a31bb76cc682
Cr-Commit-Position: refs/heads/master@{#305683}

Powered by Google App Engine
This is Rietveld 408576698