Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: breakpad/breakpad.gyp

Issue 754923002: Roll breakpad to r1405 and add microdump_stackwalk to build files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « breakpad/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad.gyp
diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp
index 39f25c4dde43148394c9f519a8100095cc45487b..038290f23906ee466d735c1388690be1cba7e086 100644
--- a/breakpad/breakpad.gyp
+++ b/breakpad/breakpad.gyp
@@ -13,9 +13,10 @@
['OS!="ios" and OS!="win"', {
'targets': [
{
- # GN version: //breakpad:minidump_stackwalk
- 'target_name': 'minidump_stackwalk',
- 'type': 'executable',
+ # code shared by both {micro,mini}dump_stackwalk
+ # GN version: //breakpad:stackwalk_common
+ 'target_name': 'stackwalk_common',
+ 'type': 'static_library',
'includes': ['breakpad_tools.gypi'],
'defines': ['BPLOG_MINIMUM_SEVERITY=SEVERITY_ERROR'],
'sources': [
@@ -32,16 +33,8 @@
'src/processor/disassembler_x86.h',
'src/processor/dump_context.cc',
'src/processor/dump_object.cc',
- 'src/processor/exploitability.cc',
- 'src/processor/exploitability_linux.cc',
- 'src/processor/exploitability_linux.h',
- 'src/processor/exploitability_win.cc',
- 'src/processor/exploitability_win.h',
'src/processor/logging.cc',
'src/processor/logging.h',
- 'src/processor/minidump.cc',
- 'src/processor/minidump_processor.cc',
- 'src/processor/minidump_stackwalk.cc',
'src/processor/pathname_stripper.cc',
'src/processor/pathname_stripper.h',
'src/processor/process_state.cc',
@@ -50,6 +43,7 @@
'src/processor/source_line_resolver_base.cc',
'src/processor/stack_frame_cpu.cc',
'src/processor/stack_frame_symbolizer.cc',
+ 'src/processor/stackwalk_common.cc',
'src/processor/stackwalker.cc',
'src/processor/stackwalker_amd64.cc',
'src/processor/stackwalker_amd64.h',
@@ -99,6 +93,37 @@
],
},
{
+ # GN version: //breakpad:microdump_stackwalk
+ 'target_name': 'microdump_stackwalk',
+ 'type': 'executable',
+ 'dependencies': ['stackwalk_common'],
+ 'includes': ['breakpad_tools.gypi'],
+ 'defines': ['BPLOG_MINIMUM_SEVERITY=SEVERITY_ERROR'],
+ 'sources': [
+ 'src/processor/microdump.cc',
+ 'src/processor/microdump_processor.cc',
+ 'src/processor/microdump_stackwalk.cc',
+ ],
+ },
+ {
+ # GN version: //breakpad:minidump_stackwalk
+ 'target_name': 'minidump_stackwalk',
+ 'type': 'executable',
+ 'dependencies': ['stackwalk_common'],
+ 'includes': ['breakpad_tools.gypi'],
+ 'defines': ['BPLOG_MINIMUM_SEVERITY=SEVERITY_ERROR'],
+ 'sources': [
+ 'src/processor/exploitability.cc',
+ 'src/processor/exploitability_linux.cc',
+ 'src/processor/exploitability_linux.h',
+ 'src/processor/exploitability_win.cc',
+ 'src/processor/exploitability_win.h',
+ 'src/processor/minidump.cc',
+ 'src/processor/minidump_processor.cc',
+ 'src/processor/minidump_stackwalk.cc',
+ ],
+ },
+ {
# GN version: //breakpad:minidump_dump
'target_name': 'minidump_dump',
'type': 'executable',
« no previous file with comments | « breakpad/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698