Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: breakpad/BUILD.gn

Issue 754923002: Roll breakpad to r1405 and add microdump_stackwalk to build files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | breakpad/breakpad.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index 884caf1ac1cbeb470275081d58f2e1b69cfe090e..bae85d6824fbc78d73e37045b810be245cb226aa 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -37,10 +37,11 @@ config("handler_config") {
]
}
-# minidump_stackwalk and minidump_dump are tool-type executables that do
+# {micro,mini}dump_stackwalk and minidump_dump are tool-type executables that do
# not build on iOS.
if (current_toolchain == host_toolchain && !is_win) {
- executable("minidump_stackwalk") {
+ # Contains the code shared by both {micro,mini}dump_stackwalk.
+ static_library("stackwalk_common") {
sources = [
"src/processor/basic_code_module.h",
"src/processor/basic_code_modules.cc",
@@ -55,12 +56,8 @@ if (current_toolchain == host_toolchain && !is_win) {
"src/processor/disassembler_x86.h",
"src/processor/dump_context.cc",
"src/processor/dump_object.cc",
- "src/processor/exploitability.cc",
"src/processor/logging.cc",
"src/processor/logging.h",
- "src/processor/minidump.cc",
- "src/processor/minidump_processor.cc",
- "src/processor/minidump_stackwalk.cc",
"src/processor/pathname_stripper.cc",
"src/processor/pathname_stripper.h",
"src/processor/process_state.cc",
@@ -69,6 +66,7 @@ if (current_toolchain == host_toolchain && !is_win) {
"src/processor/source_line_resolver_base.cc",
"src/processor/stack_frame_cpu.cc",
"src/processor/stack_frame_symbolizer.cc",
+ "src/processor/stackwalk_common.cc",
"src/processor/stackwalker.cc",
"src/processor/stackwalker_amd64.cc",
"src/processor/stackwalker_amd64.h",
@@ -122,6 +120,39 @@ if (current_toolchain == host_toolchain && !is_win) {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [ ":tools_config" ]
+ }
+
+ executable("microdump_stackwalk") {
+ sources = [
+ "src/processor/microdump.cc",
+ "src/processor/microdump_processor.cc",
+ "src/processor/microdump_stackwalk.cc",
+ ]
+
+ deps = [ ":stackwalk_common" ]
+
+ defines = [ "BPLOG_MINIMUM_SEVERITY=SEVERITY_ERROR" ]
+
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":tools_config" ]
+ }
+
+ executable("minidump_stackwalk") {
+ sources = [
+ "src/processor/exploitability.cc",
+ "src/processor/minidump.cc",
+ "src/processor/minidump_processor.cc",
+ "src/processor/minidump_stackwalk.cc",
+ ]
+
+ deps = [ ":stackwalk_common" ]
+
+ defines = [ "BPLOG_MINIMUM_SEVERITY=SEVERITY_ERROR" ]
+
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":tools_config" ]
# Always want these files included regardless of platform.
set_sources_assignment_filter([])
« no previous file with comments | « DEPS ('k') | breakpad/breakpad.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698