app_shell: Fix focus on opening new app windows

app_shell: Fix focus on opening new app windows

app_shell is pure-aura, so cannot rely on the usual views::WebView and
views::Widget initial-focus behavior. It must manually set focus on the
WebContents during creation.

BUG=438751
TEST=added to app_shell_browsertests ShellApiTest

Committed: https://crrev.com/521a0ab34bc5c60ff3545c4a4ce1aafa918c3877
Cr-Commit-Position: refs/heads/master@{#307040}

[James Cook, 2014-12-04 22:17:05]

jamescook@chromium.org changed reviewers:
+ oshima@chromium.org

[James Cook, 2014-12-04 22:17:06]

oshima, PTAL

[oshima, 2014-12-04 23:38:07]

https://codereview.chromium.org/754313003/diff/1/extensions/shell/browser/she...
File extensions/shell/browser/shell_app_delegate.cc (right):

https://codereview.chromium.org/754313003/diff/1/extensions/shell/browser/she...
extensions/shell/browser/shell_app_delegate.cc:20: Observe(web_contents);
just a q: don't you have to stop observing ?

[James Cook, 2014-12-05 02:01:50]

https://codereview.chromium.org/754313003/diff/1/extensions/shell/browser/she...
File extensions/shell/browser/shell_app_delegate.cc (right):

https://codereview.chromium.org/754313003/diff/1/extensions/shell/browser/she...
extensions/shell/browser/shell_app_delegate.cc:20: Observe(web_contents);
On 2014/12/04 23:38:07, oshima wrote:
> just a q: don't you have to stop observing ? 

No, you don't, this is a common pattern. There is only one ShellAppDelegate per
AppWindow, and the observer lifetime is managed by the WebContentsImpl and
WebContentsObserver destructors.

[oshima, 2014-12-05 02:09:08]

lgtm

[James Cook, 2014-12-05 02:10:34]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-12-05 02:11:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/754313003/1

[commit-bot: I haz the power, 2014-12-05 02:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 02:35:32]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2014-12-05 17:32:14]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-12-05 17:33:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/754313003/1

[commit-bot: I haz the power, 2014-12-05 17:47:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-05 17:48:31]

Patchset 1 (id:??) landed as
https://crrev.com/521a0ab34bc5c60ff3545c4a4ce1aafa918c3877
Cr-Commit-Position: refs/heads/master@{#307040}