Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: extensions/shell/browser/shell_browsertest.cc

Issue 754313003: app_shell: Fix focus on opening new app windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/browser/shell_browsertest.cc
diff --git a/extensions/shell/browser/shell_browsertest.cc b/extensions/shell/browser/shell_browsertest.cc
index 7d4343ebfff58387ae4d8b03483d5458002df4af..407e417f0de1cdc1424662a1453e16b8f8e7df51 100644
--- a/extensions/shell/browser/shell_browsertest.cc
+++ b/extensions/shell/browser/shell_browsertest.cc
@@ -4,15 +4,27 @@
#include "base/logging.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/test/test_utils.h"
+#include "extensions/browser/app_window/app_window.h"
+#include "extensions/browser/app_window/app_window_registry.h"
#include "extensions/browser/notification_types.h"
#include "extensions/shell/test/shell_apitest.h"
+#include "ui/aura/window.h"
namespace extensions {
// Test that we can open an app window and wait for it to load.
IN_PROC_BROWSER_TEST_F(ShellApiTest, Basic) {
ASSERT_TRUE(RunAppTest("platform_app")) << message_;
+
+ // A window was created.
+ AppWindow* app_window =
+ AppWindowRegistry::Get(browser_context())->app_windows().front();
+ ASSERT_TRUE(app_window);
+
+ // The web contents have focus.
+ EXPECT_TRUE(app_window->web_contents()->GetContentNativeView()->HasFocus());
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698