app_shell: Fix focus on opening new app windows

extensions/shell/browser/shell_app_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/shell/browser/shell_app_delegate.h"
 
+#include "content/public/browser/web_contents.h"
 #include "extensions/common/constants.h"
 #include "extensions/shell/browser/media_capture_util.h"
 
 namespace extensions {
 
 ShellAppDelegate::ShellAppDelegate() {
 }
 
 ShellAppDelegate::~ShellAppDelegate() {
 }
 
 void ShellAppDelegate::InitWebContents(content::WebContents* web_contents) {
+  Observe(web_contents);

[oshima, 2014/12/04 23:38:07]

just a q: don't you have to stop observing ? 

[James Cook, 2014/12/05 02:01:50]

No, you don't, this is a common pattern. There is only one ShellAppDelegate per
AppWindow, and the observer lifetime is managed by the WebContentsImpl and
WebContentsObserver destructors.

 }
 
 void ShellAppDelegate::ResizeWebContents(content::WebContents* web_contents,
                                          const gfx::Size& size) {
   NOTIMPLEMENTED();
 }
 
 content::WebContents* ShellAppDelegate::OpenURLFromTab(
     content::BrowserContext* context,
     content::WebContents* source,
@@ skipping 56 matching lines @@
     content::WebContents* web_contents) {
   return true;
 }
 
 void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) {
   // TODO(jamescook): Should app_shell continue to close the app window
   // manually or should it use a browser termination callback like Chrome?
   NOTIMPLEMENTED();
 }
 
+void ShellAppDelegate::RenderViewCreated(
+    content::RenderViewHost* render_view_host) {
+  // The views implementation of AppWindow takes focus via SetInitialFocus()
+  // and views::WebView but app_shell is aura-only and must do it manually.
+  web_contents()->Focus();
+}
+
 }  // namespace extensions