Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 754083002: Add Sk prefix to CreateBitmapShader. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add Sk prefix to CreateBitmapShader. It's neither static nor namespaced, so we should probably prefix it. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7ef849d45a4de02697697ea213bfae7c215a0c38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M src/core/SkBitmapProcShader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
Your bug just got me looking at this code. Should be a practical no-op. Clients ...
6 years ago (2014-11-24 16:58:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754083002/1
6 years ago (2014-11-24 17:00:03 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-11-24 17:00:03 UTC) #5
scroggo
lgtm
6 years ago (2014-11-24 17:08:30 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-24 17:12:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7ef849d45a4de02697697ea213bfae7c215a0c38

Powered by Google App Engine
This is Rietveld 408576698