src/heap/objects-visiting-inl.h - Issue 753993003: Use weak cells in map checks in polymorphic ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting-inl.h

Issue 753993003: Use weak cells in map checks in polymorphic ICs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/objects-visiting-inl.h

diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h

index 1f37306a7cd5438b86dd0c9da3b37c767d112a80..f0637932d6299e9a37c83e074cf8cff59c4b98f9 100644

--- a/src/heap/objects-visiting-inl.h

+++ b/src/heap/objects-visiting-inl.h

@@ -263,9 +263,7 @@ void StaticMarkingVisitor<StaticVisitor>::VisitCodeTarget(Heap* heap,

// to be serialized.

if (FLAG_cleanup_code_caches_at_gc && target->is_inline_cache_stub() &&

!target->is_call_stub() &&

- (target->ic_state() == MEGAMORPHIC || target->ic_state() == GENERIC ||

- target->ic_state() == POLYMORPHIC ||

mvstanton 2014/11/26 14:18:21 w00t!

- (heap->flush_monomorphic_ics() && !target->is_weak_stub()) ||

+ ((heap->flush_monomorphic_ics() && !target->is_weak_stub()) ||

heap->isolate()->serializer_enabled() ||

target->ic_age() != heap->global_ic_age() ||

target->is_invalidated_weak_stub())) {

« no previous file with comments | « no previous file | src/ic/x64/ic-compiler-x64.cc » ('j') | no next file with comments »