src/ic/x64/ic-compiler-x64.cc - Issue 753993003: Use weak cells in map checks in polymorphic ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/x64/ic-compiler-x64.cc

Issue 753993003: Use weak cells in map checks in polymorphic ICs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/x64/ic-compiler-x64.cc

diff --git a/src/ic/x64/ic-compiler-x64.cc b/src/ic/x64/ic-compiler-x64.cc

index a5848b6dda231369ee78e984bf8542de1487027c..11e6a09ea65dee382a67cb08ef91c690b6a9d7ef 100644

--- a/src/ic/x64/ic-compiler-x64.cc

+++ b/src/ic/x64/ic-compiler-x64.cc

@@ -107,10 +107,11 @@ Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types,

for (int current = 0; current < receiver_count; ++current) {

Handle<HeapType> type = types->at(current);

Handle<Map> map = IC::TypeToMap(*type, isolate());

+ Handle<WeakCell> cell = Map::WeakCellForMap(map);

if (!map->is_deprecated()) {

number_of_handled_maps++;

// Check map and tail call if there's a match

- __ Cmp(map_reg, map);

+ __ CmpWeakValue(map_reg, scratch2(), cell);

if (type->Is(HeapType::Number())) {

DCHECK(!number_case.is_unused());

__ bind(&number_case);