Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 753523002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove some calls to to-be-deprecated v8::Value::To* functions R=jochen@chromium.org TBR=kalman@chromium.org BUG= Committed: https://crrev.com/04cd96433f1b1879fc0575e10aa0ed0d5aa7fec9 Cr-Commit-Position: refs/heads/master@{#305209}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -48 lines) Patch
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M chrome/renderer/extensions/tabs_custom_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/translate/content/renderer/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/ppb_var_deprecated_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/v8_var_converter.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M content/renderer/pepper/v8_var_converter_unittest.cc View 1 3 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/v8_value_converter_impl.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/module_system_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-11-21 13:09:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753523002/20001
6 years ago (2014-11-21 13:11:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-21 13:58:21 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-21 13:58:59 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/04cd96433f1b1879fc0575e10aa0ed0d5aa7fec9
Cr-Commit-Position: refs/heads/master@{#305209}

Powered by Google App Engine
This is Rietveld 408576698