chrome/renderer/extensions/tabs_custom_bindings.cc - Issue 753523002: remove some calls to to-be-deprecated v8::Value::To* functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/tabs_custom_bindings.cc

Issue 753523002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/cast_streaming_native_handler.cc ('k') | components/translate/content/renderer/translate_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/tabs_custom_bindings.cc

diff --git a/chrome/renderer/extensions/tabs_custom_bindings.cc b/chrome/renderer/extensions/tabs_custom_bindings.cc

index ac971acd8bbefdfc990b14b17b93c81dd9e0da85..42bab695dc6a4db2d988a631986e226359f5469f 100644

--- a/chrome/renderer/extensions/tabs_custom_bindings.cc

+++ b/chrome/renderer/extensions/tabs_custom_bindings.cc

@@ -32,8 +32,8 @@ void TabsCustomBindings::OpenChannelToTab(

if (args.Length() >= 3 && args[0]->IsInt32() && args[1]->IsString() &&

args[2]->IsString()) {

int tab_id = args[0]->Int32Value();

- std::string extension_id = *v8::String::Utf8Value(args[1]->ToString());

- std::string channel_name = *v8::String::Utf8Value(args[2]->ToString());

+ std::string extension_id = *v8::String::Utf8Value(args[1]);

+ std::string channel_name = *v8::String::Utf8Value(args[2]);

int port_id = -1;

renderview->Send(new ExtensionHostMsg_OpenChannelToTab(

renderview->GetRoutingID(), tab_id, extension_id, channel_name,