Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3117)

Unified Diff: content/shell/renderer/test_runner/test_runner.cc

Issue 753523002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/test_runner.cc
diff --git a/content/shell/renderer/test_runner/test_runner.cc b/content/shell/renderer/test_runner/test_runner.cc
index d4e59240c14e8b682fdf50259aa4cab683c7dda0..2b3eefc2a6c8e2494f2a39d546adbbd5020449c8 100644
--- a/content/shell/renderer/test_runner/test_runner.cc
+++ b/content/shell/renderer/test_runner/test_runner.cc
@@ -2160,7 +2160,7 @@ void TestRunner::SetIsolatedWorldSecurityOrigin(int world_id,
WebSecurityOrigin web_origin;
if (origin->IsString()) {
web_origin = WebSecurityOrigin::createFromString(
- V8StringToWebString(origin->ToString()));
+ V8StringToWebString(origin.As<v8::String>()));
}
web_view_->focusedFrame()->setIsolatedWorldSecurityOrigin(world_id,
web_origin);
@@ -2479,7 +2479,9 @@ void TestRunner::OverridePreference(const std::string key,
} else if (key == "WebKitMinimumFontSize") {
prefs->minimum_font_size = value->Int32Value();
} else if (key == "WebKitDefaultTextEncodingName") {
- prefs->default_text_encoding_name = V8StringToWebString(value->ToString());
+ v8::Isolate* isolate = blink::mainThreadIsolate();
+ prefs->default_text_encoding_name =
+ V8StringToWebString(value->ToString(isolate));
} else if (key == "WebKitJavaScriptEnabled") {
prefs->java_script_enabled = value->BooleanValue();
} else if (key == "WebKitSupportsMultipleWindows") {
« no previous file with comments | « content/renderer/v8_value_converter_impl.cc ('k') | content/shell/renderer/test_runner/web_ax_object_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698