Issue 753123002: HTML select element should return ComboBoxRole when multiple attr is not present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 753123002: HTML select element should return ComboBoxRole when multiple attr is not present. (Closed)

Created:
6 years ago by shreeramk

Modified:
6 years ago

Reviewers:
dmazzoni

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

HTML select element should return ComboBoxRole when multiple attr is not present. On mac, html select element should be exposed as AXRole: AXComboBox AXSubrole: <nil> AXRoleDescription: 'combo box' BUG=169564 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185904

Patch Set 1 #

Patch Set 2 : #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	LayoutTests/TestExpectations	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	Source/modules/accessibility/AXNodeObject.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753123002/20001

6 years ago (2014-11-24 19:53:49 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=185904

6 years ago (2014-11-24 21:15:00 UTC) #6

shreeramk

6 years ago (2014-11-25 13:20:00 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/754373002/ by shreeram.k@samsung.com.

The reason for reverting is: This CL is not required.

Exposing AXComboBox on mac using the change from chromium side in this CL
https://codereview.chromium.org/750933002/.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages