Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 753123002: HTML select element should return ComboBoxRole when multiple attr is not present. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 if (type == InputTypeNames::range) 234 if (type == InputTypeNames::range)
235 return SliderRole; 235 return SliderRole;
236 if (type == InputTypeNames::color) 236 if (type == InputTypeNames::color)
237 return ColorWellRole; 237 return ColorWellRole;
238 if (type == InputTypeNames::time) 238 if (type == InputTypeNames::time)
239 return TimeRole; 239 return TimeRole;
240 return TextFieldRole; 240 return TextFieldRole;
241 } 241 }
242 if (isHTMLSelectElement(*node())) { 242 if (isHTMLSelectElement(*node())) {
243 HTMLSelectElement& selectElement = toHTMLSelectElement(*node()); 243 HTMLSelectElement& selectElement = toHTMLSelectElement(*node());
244 return selectElement.multiple() ? ListBoxRole : PopUpButtonRole; 244 return selectElement.multiple() ? ListBoxRole : ComboBoxRole;
245 } 245 }
246 if (isHTMLTextAreaElement(*node())) 246 if (isHTMLTextAreaElement(*node()))
247 return TextAreaRole; 247 return TextAreaRole;
248 if (headingLevel()) 248 if (headingLevel())
249 return HeadingRole; 249 return HeadingRole;
250 if (isHTMLDivElement(*node())) 250 if (isHTMLDivElement(*node()))
251 return DivRole; 251 return DivRole;
252 if (isHTMLMeterElement(*node())) 252 if (isHTMLMeterElement(*node()))
253 return MeterRole; 253 return MeterRole;
254 if (isHTMLOutputElement(*node())) 254 if (isHTMLOutputElement(*node()))
(...skipping 1570 matching lines...) Expand 10 before | Expand all | Expand 10 after
1825 float range = maxValueForRange() - minValueForRange(); 1825 float range = maxValueForRange() - minValueForRange();
1826 float value = valueForRange(); 1826 float value = valueForRange();
1827 1827
1828 value += range * (percentChange / 100); 1828 value += range * (percentChange / 100);
1829 setValue(String::number(value)); 1829 setValue(String::number(value));
1830 1830
1831 axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true); 1831 axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true);
1832 } 1832 }
1833 1833
1834 } // namespace blink 1834 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698