Source/modules/accessibility/AXNodeObject.cpp - Issue 753123002: HTML select element should return ComboBoxRole when multiple attr is not present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 753123002: HTML select element should return ComboBoxRole when multiple attr is not present. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index 269e81a68ac453d64ecf20362e459ff6bc229a88..0c48604e24cc159bbbe577b692bd0c8e31d91d57 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -241,7 +241,7 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()

}

if (isHTMLSelectElement(*node())) {

HTMLSelectElement& selectElement = toHTMLSelectElement(*node());

- return selectElement.multiple() ? ListBoxRole : PopUpButtonRole;

+ return selectElement.multiple() ? ListBoxRole : ComboBoxRole;

}

if (isHTMLTextAreaElement(*node()))

return TextAreaRole;

« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »