Source/bindings/v8/V8EventListenerList.h - Issue 75163003: Remove deprecated v8::External::New calls (blink side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8EventListenerList.h

Issue 75163003: Remove deprecated v8::External::New calls (blink side) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8EventListenerList.h

diff --git a/Source/bindings/v8/V8EventListenerList.h b/Source/bindings/v8/V8EventListenerList.h

index 78f3b84770f3f61a209c69d96251a9e9fdeab983..544f37bd52073b0b18ae2599f5b45383325f4672 100644

--- a/Source/bindings/v8/V8EventListenerList.h

+++ b/Source/bindings/v8/V8EventListenerList.h

@@ -105,7 +105,7 @@ PassRefPtr<V8EventListener> V8EventListenerList::findOrCreateWrapper(v8::Local<v

RefPtr<V8EventListener> wrapperPtr = WrapperType::create(object, isAttribute, isolate);

if (wrapperPtr)

- object->SetHiddenValue(wrapperProperty, v8::External::New(wrapperPtr.get()));

+ object->SetHiddenValue(wrapperProperty, v8::External::New(isolate, wrapperPtr.get()));

return wrapperPtr;

}