Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 751043002: Refactor RenderView creation to use ViewMsg_New_Params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Charlie's review. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 442217f26130e16084f29408395bed6ae26aa7de..f4ad0efd3970d6e7e53d8991fc4cac6a47603116 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -1363,25 +1363,7 @@ void RenderThreadImpl::OnSetZoomLevelForCurrentURL(const std::string& scheme,
void RenderThreadImpl::OnCreateNewView(const ViewMsg_New_Params& params) {
EnsureWebKitInitialized();
// When bringing in render_view, also bring in webkit's glue and jsbindings.
- RenderViewImpl::Create(params.opener_route_id,
- params.window_was_created_with_opener,
- params.renderer_preferences,
- params.web_preferences,
- params.view_id,
- params.main_frame_routing_id,
- params.surface_id,
- params.session_storage_namespace_id,
- params.frame_name,
- false,
- params.swapped_out,
- params.proxy_routing_id,
- params.hidden,
- params.never_visible,
- params.next_page_id,
- params.initial_size,
- params.enable_auto_resize,
- params.min_size,
- params.max_size);
+ RenderViewImpl::Create(params, false);
}
GpuChannelHost* RenderThreadImpl::EstablishGpuChannelSync(
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698