Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2678)

Unified Diff: content/public/test/render_view_test.cc

Issue 751043002: Refactor RenderView creation to use ViewMsg_New_Params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Charlie's review. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index f931461c700ac94789f5901d4a45cffe1d92be2c..0b43c358105a4e2ee0dca721b4ff37e010fff73f 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -187,28 +187,28 @@ void RenderViewTest::SetUp() {
mock_process_.reset(new MockRenderProcess);
+ ViewMsg_New_Params view_params;
+ view_params.opener_route_id = kOpenerId;
+ view_params.window_was_created_with_opener = false;
+ view_params.renderer_preferences = RendererPreferences();
+ view_params.web_preferences = WebPreferences();
+ view_params.view_id = kRouteId;
+ view_params.main_frame_routing_id = kMainFrameRouteId;
+ view_params.surface_id = kSurfaceId;
+ view_params.session_storage_namespace_id = kInvalidSessionStorageNamespaceId;
+ view_params.frame_name = base::string16();
+ view_params.swapped_out = false;
+ view_params.proxy_routing_id = MSG_ROUTING_NONE;
+ view_params.hidden = false;
+ view_params.never_visible = false;
+ view_params.next_page_id = 1;
+ view_params.initial_size = *InitialSizeParams();
+ view_params.enable_auto_resize = false;
+ view_params.min_size = gfx::Size();
+ view_params.max_size = gfx::Size();
+
// This needs to pass the mock render thread to the view.
- RenderViewImpl* view =
- RenderViewImpl::Create(kOpenerId,
- false, // window_was_created_with_opener
- RendererPreferences(),
- WebPreferences(),
- kRouteId,
- kMainFrameRouteId,
- kSurfaceId,
- kInvalidSessionStorageNamespaceId,
- base::string16(),
- false, // is_renderer_created
- false, // swapped_out
- MSG_ROUTING_NONE, // proxy_routing_id
- false, // hidden
- false, // never_visible
- 1, // next_page_id
- *InitialSizeParams(),
- false, // enable_auto_resize
- gfx::Size(), // min_size
- gfx::Size() // max_size
- );
+ RenderViewImpl* view = RenderViewImpl::Create(view_params, false);
view->AddRef();
view_ = view;
}
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698