Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: content/renderer/render_view_impl.h

Issue 751043002: Refactor RenderView creation to use ViewMsg_New_Params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Charlie's review. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index 6616acd91677e27344337b0865de62187bdaac5a..c6eb3642eb2bb41115370f764a7597f682998213 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -77,6 +77,7 @@ class PepperDeviceTest;
class SkBitmap;
struct PP_NetAddress_Private;
struct FrameMsg_Navigate_Params;
+struct ViewMsg_New_Params;
struct ViewMsg_PostMessage_Params;
struct ViewMsg_Resize_Params;
struct ViewMsg_StopFinding_Params;
@@ -164,30 +165,13 @@ class CONTENT_EXPORT RenderViewImpl
// |opener_id| will be MSG_ROUTING_NONE. When |swapped_out| is true, the
// |proxy_routing_id| is specified, so a RenderFrameProxy can be created for
// this RenderView's main RenderFrame.
- static RenderViewImpl* Create(int32 opener_id,
- bool window_was_created_with_opener,
- const RendererPreferences& renderer_prefs,
- const WebPreferences& webkit_prefs,
- int32 routing_id,
- int32 main_frame_routing_id,
- int32 surface_id,
- int64 session_storage_namespace_id,
- const base::string16& frame_name,
- bool is_renderer_created,
- bool swapped_out,
- int32 proxy_routing_id,
- bool hidden,
- bool never_visible,
- int32 next_page_id,
- const ViewMsg_Resize_Params& initial_size,
- bool enable_auto_resize,
- const gfx::Size& min_size,
- const gfx::Size& max_size);
+ static RenderViewImpl* Create(const ViewMsg_New_Params& params,
+ bool was_created_by_renderer);
// Used by content_layouttest_support to hook into the creation of
// RenderViewImpls.
static void InstallCreateHook(
- RenderViewImpl* (*create_render_view_impl)(RenderViewImplParams*));
+ RenderViewImpl* (*create_render_view_impl)(const ViewMsg_New_Params&));
// Returns the RenderViewImpl containing the given WebView.
static RenderViewImpl* FromWebView(blink::WebView* webview);
@@ -539,9 +523,10 @@ class CONTENT_EXPORT RenderViewImpl
void InstrumentWillComposite() override;
protected:
- explicit RenderViewImpl(RenderViewImplParams* params);
+ explicit RenderViewImpl(const ViewMsg_New_Params& params);
- void Initialize(RenderViewImplParams* params);
+ void Initialize(const ViewMsg_New_Params& params,
+ bool was_created_by_renderer);
void SetScreenMetricsEmulationParameters(float device_scale_factor,
const gfx::Point& root_layer_offset,
float root_layer_scale) override;
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698