pkg/compiler/lib/src/js_backend/codegen/codegen.dart - Issue 750323003: Remove js.ArrayElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 750323003: Remove js.ArrayElement. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add parsing and testing of array holes, make lists non-growable Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js/template.dart ('K') | « pkg/compiler/lib/src/js/template.dart ('k') | pkg/compiler/lib/src/js_backend/constant_emitter.dart » ('j') | pkg/compiler/lib/src/js_backend/runtime_types.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

index 308e1af95fc567228f68951f6ba4f2ae094cc796..f988e36e19ac7980af2a8ccf3fd1684f7b0f4d22 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

@@ -226,9 +226,8 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {

js.Expression visitLiteralList(tree_ir.LiteralList node) {

registry.registerInstantiatedClass(glue.listClass);

int length = node.values.length;

- List<js.ArrayElement> entries = new List<js.ArrayElement>.generate(length,

- (int i) => new js.ArrayElement(i, visitExpression(node.values[i])));

- return new js.ArrayInitializer(length, entries);

+ List<js.Expression> entries = node.values.map(visitExpression).toList();

+ return new js.ArrayInitializer(entries);

}

@override

@@ -239,17 +238,14 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {

} else {

constructor = glue.mapLiteralConstructor;

}

- List<js.ArrayElement> entries =

- new List<js.ArrayElement>(2 * node.entries.length);

+ List<js.Expression> entries =

+ new List<js.Expression>(2 * node.entries.length);

for (int i = 0; i < node.entries.length; i++) {

- js.Expression key = visitExpression(node.entries[i].key);

- js.Expression value = visitExpression(node.entries[i].value);

- entries[2 * i] = new js.ArrayElement(2 * i, key);

- entries[2 * i + 1] = new js.ArrayElement(2 * i + 1, value);

+ entries[2 * i] = visitExpression(node.entries[i].key);

+ entries[2 * i + 1] = visitExpression(node.entries[i].value);

}

List<js.Expression> args =

- <js.Expression>[new js.ArrayInitializer(node.entries.length * 2,

- entries)];

+ <js.Expression>[new js.ArrayInitializer(entries)];

return buildStaticInvoke(

new Selector.call(constructor.name, constructor.library, 2),

constructor,