Chromium Code Reviews| Index: pkg/compiler/lib/src/js_backend/runtime_types.dart |
| diff --git a/pkg/compiler/lib/src/js_backend/runtime_types.dart b/pkg/compiler/lib/src/js_backend/runtime_types.dart |
| index f32d77fe9d7c8db25064145476b8b5859d5e7954..4c77eeecb9a44cc8ff943de8e30c9f80a5c64108 100644 |
| --- a/pkg/compiler/lib/src/js_backend/runtime_types.dart |
| +++ b/pkg/compiler/lib/src/js_backend/runtime_types.dart |
| @@ -506,13 +506,10 @@ class RuntimeTypes { |
| jsAst.Expression getSubstitutionRepresentation( |
| List<DartType> types, |
| OnVariableCallback onVariable) { |
| - List<jsAst.ArrayElement> elements = <jsAst.ArrayElement>[]; |
| - int index = 0; |
| - for (DartType type in types) { |
| - jsAst.Expression representation = getTypeRepresentation(type, onVariable); |
| - elements.add(new jsAst.ArrayElement(index++, representation)); |
| - } |
| - return new jsAst.ArrayInitializer(index, elements); |
| + List<jsAst.Expression> elements = |
| + types.map((DartType type) => getTypeRepresentation(type, onVariable)) |
|
floitsch
2014/12/01 13:03:29
nit.
I prefer to keep "types" in the line above, a
sigurdm
2014/12/02 09:27:31
Done.
|
| + .toList(growable: false); |
| + return new jsAst.ArrayInitializer(elements); |
| } |
| jsAst.Expression getTypeEncoding(DartType type, |
| @@ -657,15 +654,15 @@ class TypeRepresentationGenerator extends DartTypeVisitor { |
| jsAst.Expression visitList(List<DartType> types, {jsAst.Expression head}) { |
| int index = 0; |
| - List<jsAst.ArrayElement> elements = <jsAst.ArrayElement>[]; |
| + List<jsAst.Expression> elements = <jsAst.Expression>[]; |
| if (head != null) { |
| - elements.add(new jsAst.ArrayElement(0, head)); |
| + elements.add(head); |
| index++; |
| } |
| for (DartType type in types) { |
| - elements.add(new jsAst.ArrayElement(index++, visit(type))); |
| + elements.add(visit(type)); |
| } |
| - return new jsAst.ArrayInitializer(elements.length, elements); |
| + return new jsAst.ArrayInitializer(elements); |
| } |
| visitFunctionType(FunctionType type, _) { |