Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: pkg/compiler/lib/src/js_backend/constant_emitter.dart

Issue 750323003: Remove js.ArrayElement. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add parsing and testing of array holes, make lists non-growable Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/constant_emitter.dart
diff --git a/pkg/compiler/lib/src/js_backend/constant_emitter.dart b/pkg/compiler/lib/src/js_backend/constant_emitter.dart
index 015d6dfd45dca2f178a02c653b6c334570e35698..4afb1359c30aa5bee56330b128b0f6a39ddf3052 100644
--- a/pkg/compiler/lib/src/js_backend/constant_emitter.dart
+++ b/pkg/compiler/lib/src/js_backend/constant_emitter.dart
@@ -234,7 +234,7 @@ class ConstantLiteralEmitter implements ConstantValueVisitor<jsAst.Expression> {
jsAst.Expression visitList(ListConstantValue constant) {
List<jsAst.Expression> elements = _array(constant.entries);
- jsAst.ArrayInitializer array = new jsAst.ArrayInitializer.from(elements);
+ jsAst.ArrayInitializer array = new jsAst.ArrayInitializer(elements);
jsAst.Expression value = makeConstantListTemplate.instantiate([array]);
return maybeAddTypeArguments(constant.type, value);
}
@@ -271,7 +271,7 @@ class ConstantLiteralEmitter implements ConstantValueVisitor<jsAst.Expression> {
data.add(keyExpression);
data.add(valueExpression);
}
- return new jsAst.ArrayInitializer.from(data);
+ return new jsAst.ArrayInitializer(data);
}
ClassElement classElement = constant.type.element;
@@ -362,11 +362,7 @@ class ConstantLiteralEmitter implements ConstantValueVisitor<jsAst.Expression> {
}
List<jsAst.Expression> _array(List<ConstantValue> values) {
- List<jsAst.Expression> valueList = <jsAst.Expression>[];
- for (int i = 0; i < values.length; i++) {
- valueList.add(constantEmitter.reference(values[i]));
- }
- return valueList;
+ return values.map(constantEmitter.reference).toList(growable: false);
}
jsAst.Expression maybeAddTypeArguments(InterfaceType type,

Powered by Google App Engine
This is Rietveld 408576698