Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 750173002: Move dip utils to gfx/geometry (Closed)

Created:
6 years, 1 month ago by ccameron
Modified:
6 years ago
Reviewers:
danakj, jbauman
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, Ian Vollick, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move dip utils to gfx/geometry This was being replicated in content and in compositor. Let's find a home for it. BUG=424058 R=jbauman TBR=danakj Committed: https://crrev.com/9ac1a2f65deef7823b1d3b7c4325727161d37917 Cr-Commit-Position: refs/heads/master@{#305666}

Patch Set 1 #

Patch Set 2 : Simplify #

Patch Set 3 : Rebase #

Patch Set 4 : Add missed android change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -69 lines) Patch
M content/browser/compositor/browser_compositor_ca_layer_tree_mac.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/dip_util.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/dip_util.cc View 2 chunks +4 lines, -27 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/software_frame_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/compositor/dip_util.cc View 2 chunks +8 lines, -21 lines 0 comments Download
M ui/gfx/geometry/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/gfx/geometry/dip_util.h View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A ui/gfx/geometry/dip_util.cc View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ccameron
This finally got to be too much of a hassle to ignore when moving the ...
6 years, 1 month ago (2014-11-21 23:11:50 UTC) #2
ccameron
Pinging this
6 years ago (2014-11-24 18:02:37 UTC) #3
ccameron
Ping again.
6 years ago (2014-11-25 01:26:57 UTC) #4
jbauman
lgtm
6 years ago (2014-11-25 01:29:35 UTC) #5
ccameron
Using TBR for now -- let me know if you'd like this done differently.
6 years ago (2014-11-25 17:35:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750173002/60001
6 years ago (2014-11-25 17:36:31 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-11-25 18:34:35 UTC) #9
commit-bot: I haz the power
6 years ago (2014-11-25 18:35:18 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9ac1a2f65deef7823b1d3b7c4325727161d37917
Cr-Commit-Position: refs/heads/master@{#305666}

Powered by Google App Engine
This is Rietveld 408576698