Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 749693005: Remove SearchButton. (Closed)

Created:
6 years ago by groby-ooo-7-16
Modified:
5 years, 10 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, tfarina, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@no-origin-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SearchButton. As our old friend OriginChip, so the SearchButton too has to bid adieu. She served well, and we shall miss her. BUG=424751 Committed: https://crrev.com/dcf300ae062ae29c02bba5b0559d006b24814867 Cr-Commit-Position: refs/heads/master@{#316302}

Patch Set 1 #

Patch Set 2 : Remove SearchButton on OSX as well. #

Patch Set 3 : Rebase to HEAD #

Patch Set 4 : Fix bad merge. #

Patch Set 5 : Merge to HEAD #

Patch Set 6 : Merge to HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -435 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/search/search.h View 1 2 3 4 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/search/search.cc View 1 2 3 4 2 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm View 1 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 4 4 chunks +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/cocoa/location_bar/search_button_decoration.h View 1 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/cocoa/location_bar/search_button_decoration.mm View 1 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 1 2 3 4 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 12 chunks +6 lines, -54 lines 0 comments Download
D chrome/browser/ui/views/location_bar/search_button.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/views/location_bar/search_button.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
groby-ooo-7-16
PTAL at SearchButton removal as well. Note: Did most of the digging for references via ...
6 years ago (2014-12-02 21:18:10 UTC) #2
groby-ooo-7-16
If you'd rather review a single CL for OriginChip and SearchButton: https://codereview.chromium.org/768413003/
6 years ago (2014-12-02 22:41:57 UTC) #3
Justin Donnelly
LGTM Made some comments on the merged CL, but in general lgtm.
6 years ago (2014-12-03 16:08:33 UTC) #4
groby-ooo-7-16
kmadhusu: Please review c/b/search.
5 years, 11 months ago (2015-01-10 02:18:32 UTC) #6
kmadhusu
On 2015/01/10 02:18:32, groby wrote: > kmadhusu: Please review c/b/search. lgm
5 years, 11 months ago (2015-01-12 17:49:27 UTC) #7
groby-ooo-7-16
kmadhusu: Please LG (previous one was not parsed due to misspelling, no new changes) pkasting: ...
5 years, 10 months ago (2015-02-12 03:11:53 UTC) #8
Peter Kasting
Rubber-stamp LGTM (I assume you'll land the origin chip change first and then run tryjobs ...
5 years, 10 months ago (2015-02-12 07:07:14 UTC) #9
groby-ooo-7-16
Yep, that's the plan. On Wed, Feb 11, 2015 at 11:07 PM, <pkasting@chromium.org> wrote: > ...
5 years, 10 months ago (2015-02-13 02:58:18 UTC) #10
groby-ooo-7-16
kmadhusu: Mind LG'ing again so this can land?
5 years, 10 months ago (2015-02-13 20:58:46 UTC) #12
kmadhusu
On 2015/02/13 20:58:46, groby wrote: > kmadhusu: Mind LG'ing again so this can land? LGTM.
5 years, 10 months ago (2015-02-13 21:41:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749693005/100001
5 years, 10 months ago (2015-02-13 21:57:43 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-13 22:02:35 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 22:03:02 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/dcf300ae062ae29c02bba5b0559d006b24814867
Cr-Commit-Position: refs/heads/master@{#316302}

Powered by Google App Engine
This is Rietveld 408576698