Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 749693005: Remove SearchButton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-origin-2
Patch Set: Merge to HEAD Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 chromeos::switches::kAggressiveCacheDiscardThreshold }, 317 chromeos::switches::kAggressiveCacheDiscardThreshold },
318 { IDS_FLAGS_AGGRESSIVE_TAB_DISCARD_THRESHOLDS, 318 { IDS_FLAGS_AGGRESSIVE_TAB_DISCARD_THRESHOLDS,
319 chromeos::switches::kMemoryPressureThresholds, 319 chromeos::switches::kMemoryPressureThresholds,
320 chromeos::switches::kAggressiveTabDiscardThreshold }, 320 chromeos::switches::kAggressiveTabDiscardThreshold },
321 { IDS_FLAGS_AGGRESSIVE_THRESHOLDS, 321 { IDS_FLAGS_AGGRESSIVE_THRESHOLDS,
322 chromeos::switches::kMemoryPressureThresholds, 322 chromeos::switches::kMemoryPressureThresholds,
323 chromeos::switches::kAggressiveThreshold }, 323 chromeos::switches::kAggressiveThreshold },
324 }; 324 };
325 #endif 325 #endif
326 326
327 // We're using independent flags here (as opposed to a common flag with
328 // different values) to be able to enable/disable the entire experience
329 // associated with this feature server-side from the FieldTrial (the complete
330 // experience includes other flag changes as well). It is not currently possible
331 // to do that with "flag=value" flags.
332 const Experiment::Choice kSearchButtonInOmniboxChoices[] = {
333 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
334 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
335 switches::kDisableSearchButtonInOmnibox, ""},
336 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR,
337 switches::kEnableSearchButtonInOmniboxForStr, ""},
338 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR_OR_IIP,
339 switches::kEnableSearchButtonInOmniboxForStrOrIip, ""},
340 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED,
341 switches::kEnableSearchButtonInOmniboxAlways, ""}
342 };
343
344 const Experiment::Choice kExtensionContentVerificationChoices[] = { 327 const Experiment::Choice kExtensionContentVerificationChoices[] = {
345 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 328 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
346 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_BOOTSTRAP, 329 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_BOOTSTRAP,
347 switches::kExtensionContentVerification, 330 switches::kExtensionContentVerification,
348 switches::kExtensionContentVerificationBootstrap }, 331 switches::kExtensionContentVerificationBootstrap },
349 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_ENFORCE, 332 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_ENFORCE,
350 switches::kExtensionContentVerification, 333 switches::kExtensionContentVerification,
351 switches::kExtensionContentVerificationEnforce }, 334 switches::kExtensionContentVerificationEnforce },
352 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_ENFORCE_STRICT, 335 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_ENFORCE_STRICT,
353 switches::kExtensionContentVerification, 336 switches::kExtensionContentVerification,
(...skipping 1323 matching lines...) Expand 10 before | Expand all | Expand 10 after
1677 }, 1660 },
1678 #endif 1661 #endif
1679 { 1662 {
1680 "num-raster-threads", 1663 "num-raster-threads",
1681 IDS_FLAGS_NUM_RASTER_THREADS_NAME, 1664 IDS_FLAGS_NUM_RASTER_THREADS_NAME,
1682 IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION, 1665 IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION,
1683 kOsAll, 1666 kOsAll,
1684 MULTI_VALUE_TYPE(kNumRasterThreadsChoices) 1667 MULTI_VALUE_TYPE(kNumRasterThreadsChoices)
1685 }, 1668 },
1686 { 1669 {
1687 "search-button-in-omnibox",
1688 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME,
1689 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION,
1690 kOsCrOS | kOsMac | kOsWin | kOsLinux,
1691 MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices)
1692 },
1693 {
1694 "ignore-autocomplete-off-autofill", 1670 "ignore-autocomplete-off-autofill",
1695 IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_NAME, 1671 IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_NAME,
1696 IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_DESCRIPTION, 1672 IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_DESCRIPTION,
1697 kOsCrOS | kOsMac | kOsWin | kOsLinux, 1673 kOsCrOS | kOsMac | kOsWin | kOsLinux,
1698 ENABLE_DISABLE_VALUE_TYPE( 1674 ENABLE_DISABLE_VALUE_TYPE(
1699 autofill::switches::kIgnoreAutocompleteOffForAutofill, 1675 autofill::switches::kIgnoreAutocompleteOffForAutofill,
1700 autofill::switches::kRespectAutocompleteOffForAutofill) 1676 autofill::switches::kRespectAutocompleteOffForAutofill)
1701 }, 1677 },
1702 { 1678 {
1703 "enable-single-click-autofill", 1679 "enable-single-click-autofill",
(...skipping 1049 matching lines...) Expand 10 before | Expand all | Expand 10 after
2753 } 2729 }
2754 2730
2755 const Experiment* GetExperiments(size_t* count) { 2731 const Experiment* GetExperiments(size_t* count) {
2756 *count = num_experiments; 2732 *count = num_experiments;
2757 return experiments; 2733 return experiments;
2758 } 2734 }
2759 2735
2760 } // namespace testing 2736 } // namespace testing
2761 2737
2762 } // namespace about_flags 2738 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698