Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5480)

Unified Diff: chrome/browser/about_flags.cc

Issue 749693005: Remove SearchButton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-origin-2
Patch Set: Merge to HEAD Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 57e4cce29bad8201a5146018892434efed9bcc27..093457a984261ec3168b5ca5255d88a8d0a36381 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -324,23 +324,6 @@ const Experiment::Choice kMemoryPressureThresholdChoices[] = {
};
#endif
-// We're using independent flags here (as opposed to a common flag with
-// different values) to be able to enable/disable the entire experience
-// associated with this feature server-side from the FieldTrial (the complete
-// experience includes other flag changes as well). It is not currently possible
-// to do that with "flag=value" flags.
-const Experiment::Choice kSearchButtonInOmniboxChoices[] = {
- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
- { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
- switches::kDisableSearchButtonInOmnibox, ""},
- { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR,
- switches::kEnableSearchButtonInOmniboxForStr, ""},
- { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR_OR_IIP,
- switches::kEnableSearchButtonInOmniboxForStrOrIip, ""},
- { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED,
- switches::kEnableSearchButtonInOmniboxAlways, ""}
-};
-
const Experiment::Choice kExtensionContentVerificationChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_BOOTSTRAP,
@@ -1684,13 +1667,6 @@ const Experiment kExperiments[] = {
MULTI_VALUE_TYPE(kNumRasterThreadsChoices)
},
{
- "search-button-in-omnibox",
- IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME,
- IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION,
- kOsCrOS | kOsMac | kOsWin | kOsLinux,
- MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices)
- },
- {
"ignore-autocomplete-off-autofill",
IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_NAME,
IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_DESCRIPTION,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698