Use remove_build_metadata.py on all the trybots (take 3).

Use remove_build_metadata.py on all the trybots (take 3).

Revert of Issue 708993002: Revert "Use remove_build_metadata.py on all the trybots (take 2)." : https://codereview.chromium.org/708993002/

Problems have been fixed on zap_timestamp: https://code.google.com/p/syzygy/source/detail?r=ae952911d466b1c00b446e2a7bae5ed4d8c2adea

TBR=phajdan.jr@chromium.org
R=maruel@chromium.org

BUG=314403
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293067

[Sébastien Marchand, 2014-11-21 19:18:13]

PTAL.

[M-A Ruel, 2014-11-21 19:25:09]

I assume the _ng bot means it's a bit more complicated in practice.

https://codereview.chromium.org/748153002/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/748153002/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_trybot.py:932: # Remove the build metadata from
the binaries. Currently it's a noop on
The command is not exactly right due to android, I recommend removing the second
sentence.

[Sébastien Marchand, 2014-11-21 19:34:24]

Thanks, comment addressed.

https://codereview.chromium.org/748153002/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/748153002/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_trybot.py:932: # Remove the build metadata from
the binaries. Currently it's a noop on
On 2014/11/21 19:25:09, M-A Ruel wrote:
> The command is not exactly right due to android, I recommend removing the
second
> sentence.

Done.

[M-A Ruel, 2014-11-21 19:37:20]

lgtm

[Sébastien Marchand, 2014-11-21 19:44:01]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2014-11-21 19:44:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/748153002/20001

[commit-bot: I haz the power, 2014-11-21 19:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-21 19:46:09]

Presubmit check for 748153002-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
scripts/slave/unittests/recipe_simulation_test.py (24.90s) failed
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F...................................F........F.F.F.......F..F..................................F....................................................F...........................................................................................................................................................................................................................................................................................................................................................................

======================================================================
FAIL: chromium_trybot.full_tryserver_chromium_linux_linux_arm
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 143,150 ****
--- 143,159 ----
            'mojo_common_unittests'],
    'name': 'compile (with patch)'},
   {'cmd': ['python',
            '-u',
+          
'[BUILD]/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py',
+           '--build-dir',
+           '[SLAVE_BUILD]/src/out/Release',
+           '--src-dir',
+           '[SLAVE_BUILD]/src'],
+   'cwd': '[SLAVE_BUILD]',
+   'name': 'remove_build_metadata'},
+  {'cmd': ['python',
+           '-u',
            "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n 
f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
            '/path/to/tmp/',
            '[SLAVE_BUILD]/src/out/Release/*.isolated.gen.json'],
    'name': 'find isolated targets'},

======================================================================
FAIL: chromium_trybot.compile_because_of_analyze_with_filtered_compile_targets
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 177,184 ****
--- 177,193 ----
            'chrome'],
    'name': 'compile (with patch)'},
   {'cmd': ['python',
            '-u',
+          
'[BUILD]/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py',
+           '--build-dir',
+           '[SLAVE_BUILD]/src/out/Release',
+           '--src-dir',
+           '[SLAVE_BUILD]/src'],
+   'cwd': '[SLAVE_BUILD]',
+   'name': 'remove_build_metadata'},
+  {'cmd': ['python',
+           '-u',
            "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n 
f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
            '/path/to/tmp/',
            '[SLAVE_BUILD]/src/out/Release/*.isolated.gen.json'],
    'name': 'find isolated targets'},

======================================================================
FAIL: chromium_trybot.swarming_missing_isolated
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 161,168 ****
--- 161,177 ----
            'browser_tests_run'],
    'name': 'compile (with patch)'},
   {'cmd': ['python',
            '-u',
+          
'[BUILD]/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py',
+           '--build-dir',
+           '[SLAVE_BUILD]/src/out/Release',
+           '--src-dir',
+           '[SLAVE_BUILD]/src'],
+   'cwd': '[SLAVE_BUILD]',
+   'name': 'remove_build_metadata'},
+  {'cmd': ['python',
+           '-u',
            "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n 
f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
            '/path/to/tmp/',
            '[SLAVE_BUILD]/src/out/Release/*.isolated.gen.json'],
    'name': 'find isolated targets'},

======================================================================
FAIL: chromium_trybot.swarming_basic_cq
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 163,170 ****
--- 163,179 ----
            'base_unittests_run',
            'browser_tests',
            'browser_tests_run'],
    'name': 'compile (with patch)'},
+  {'cmd': ['python',
+           '-u',
+          
'[BUILD]/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py',
+           '--build-dir',
+           '[SLAVE_BUILD]/src/out/Release',
+           '--src-dir',
+           '[SLAVE_BUILD]/src'],
+   'cwd': '[SLAVE_BUILD]',
+   'name': 'remove_build_metadata'},
   {'cmd': ['python',
            '-u',
            "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n 
f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
            '/path/to/tmp/',

======================================================================
FAIL: chromium_trybot.compile_because_of_analyze_with_filtered_tests_no_builder
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 175,182 ****
--- 175,191 ----
            'browser_tests'],
    'name': 'compile (with patch)'},
   {'cmd': ['python',
            '-u',
+          
'[BUILD]/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py',
+           '--build-dir',
+           '[SLAVE_BUILD]/src/out/Release',
+           '--src-dir',
+           '[SLAVE_BUILD]/src'],
+   'cwd': '[SLAVE_BUILD]',
+   'name': 'remove_build_metadata'},
+  {'cmd': ['python',
+           '-u',
            "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n 
f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
            '/path/to/tmp/',
            '[SLAVE_BUILD]/src/out/Release/*.isolated.gen.json'],
    'name': 'find isolated targets'},

======================================================================
FAIL: chromium_trybot.swarming_basic_try_job
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 163,170 ****
--- 163,179 ----
            'base_unittests_run',
            'browser_tests',
            'browser_tests_run'],
    'name': 'compile (with patch)'},
+  {'cmd': ['python',
+           '-u',
+          
'[BUILD]/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py',
+           '--build-dir',
+           '[SLAVE_BUILD]/src/out/Release',
+           '--src-dir',
+           '[SLAVE_BUILD]/src'],
+   'cwd': '[SLAVE_BUILD]',
+   'name': 'remove_build_metadata'},
   {'cmd': ['python',
            '-u',
            "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n 
f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
            '/path/to/tmp/',

======================================================================
FAIL: chromium_trybot.compile_because_of_analyze_with_filtered_tests
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 175,182 ****
--- 175,191 ----
            'browser_tests'],
    'name': 'compile (with patch)'},
   {'cmd': ['python',
            '-u',
+          
'[BUILD]/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py',
+           '--build-dir',
+           '[SLAVE_BUILD]/src/out/Release',
+           '--src-dir',
+           '[SLAVE_BUILD]/src'],
+   'cwd': '[SLAVE_BUILD]',
+   'name': 'remove_build_metadata'},
+  {'cmd': ['python',
+           '-u',
            "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n 
f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
            '/path/to/tmp/',
            '[SLAVE_BUILD]/src/out/Release/*.isolated.gen.json'],
    'name': 'find isolated targets'},

======================================================================
FAIL: chromium_trybot.swarming_deapply_patch
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/swarming_deapply_patch.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 161,168 ****
--- 161,177 ----
            'browser_tests_run'],
    'name': 'compile (with patch)'},
   {'cmd': ['python',
            '-u',
+          
'[BUILD]/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py',
+           '--build-dir',
+           '[SLAVE_BUILD]/src/out/Release',
+           '--src-dir',
+           '[SLAVE_BUILD]/src'],
+   'cwd': '[SLAVE_BUILD]',
+   'name': 'remove_build_metadata'},
+  {'cmd': ['python',
+           '-u',
            "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n 
f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
       …
(message too large)

[Sébastien Marchand, 2014-11-21 19:55:48]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2014-11-21 19:56:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/748153002/40001

[commit-bot: I haz the power, 2014-11-21 19:58:30]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293067