Use remove_build_metadata.py on all the trybots (take 3).

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 DEPS = [
   'bot_update',
   'chromium',
   'chromium_tests',
   'gclient',
   'gpu',
@@ skipping 911 matching lines @@
         # TODO(phajdan.jr): Set failed tryjob result after recognizing infra
         # compile failures. We've seen cases of compile with patch failing
         # with build steps getting killed, compile without patch succeeding,
         # and compile with patch succeeding on another attempt with same patch.
       except api.step.StepFailure:
         api.tryserver.set_transient_failure_tryjob_result()
         raise
       raise
 
     if bot_config.get('use_isolate') or has_swarming_tests:
-      # TODO(sebmarchand): remove_build_metadata, http://crbug.com/314403 .
+      # Remove the build metadata from the binaries. Currently it's a noop on

[M-A Ruel, 2014/11/21 19:25:09]

The command is not exactly right due to android, I recommend removing the second
sentence.

[Sébastien Marchand, 2014/11/21 19:34:24]

Done.

+      # all platforms except Windows where it run zap_timestamp.exe on all the
+      # PE images.
+      api.isolate.remove_build_metadata()
       # Isolate all prepared targets, will look for *.isolated.gen.json files.
       api.isolate.isolate_tests(api.chromium.output_dir, verbose=True)
 
     if bot_config['compile_only']:
       tests = []
 
     return tests, bot_update_step
 
   mastername = api.properties.get('mastername')
   buildername = api.properties.get('buildername')
@@ skipping 638 matching lines @@
       enable_gpu_tests=True,
     ) +
     api.platform.name('mac') +
     api.override_step_data(
         'pixel_test on Intel GPU (with patch) on Mac',
         api.json.canned_telemetry_gpu_output(passing=False, swarming=True)) +
     api.override_step_data(
         'pixel_test on Intel GPU (without patch) on Mac',
         api.json.canned_telemetry_gpu_output(passing=False, swarming=True))
   )