scripts/slave/recipes/chromium_trybot.py - Issue 748153002: Use remove_build_metadata.py on all the trybots (take 3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 748153002: Use remove_build_metadata.py on all the trybots (take 3). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Update the test expectations Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index b5db1169577abeea13e2ff46c954b5c88fb27c19..bcba42083fe728b3bde517fd1feebd360e6372c4 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -929,7 +929,8 @@ def GenSteps(api):

raise

if bot_config.get('use_isolate') or has_swarming_tests:

- # TODO(sebmarchand): remove_build_metadata, http://crbug.com/314403 .

+ # Remove the build metadata from the binaries.

+ api.isolate.remove_build_metadata()

# Isolate all prepared targets, will look for *.isolated.gen.json files.

api.isolate.isolate_tests(api.chromium.output_dir, verbose=True)